Issue 6272028: Delete tab_loader when there are no more tabs to be loaded or painted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6272028: Delete tab_loader when there are no more tabs to be loaded or painted (Closed)

Created:
9 years, 10 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Delete tab_loader when there are no more tabs to be loaded or painted BUG=6371017 TEST=Valgrind of RunInBackgroundTest.RunInBackgroundBasicTest doesn't leak after revert of http://src.chromium.org/viewvc/chrome?view=rev&revision=72968 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73013

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/sessions/session_restore.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

DaveMoore

I wasn't deleting the tab loader if all tabs were closed (or window closed) before ...

9 years, 10 months ago (2011-01-28 20:06:18 UTC) #1

Also, you need to update the suppressions too.

  -Scott