Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 627163002: Suppress readability/inheritance check for cpplint.py for now. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Suppress readability/inheritance check for cpplint.py for now. This check never triggered before, since cpplint.py was looking for override not OVERRIDE. Since Chromium prefers override now, the linter is now (correctly) warning. However, the old Chromium convention (and the one implemented by the clang plugin) is to explicitly annotate all overrides with both virtual and override. The clang plugin code has been updated, but new binaries have not yet been built. Until clang rolls, suppress the warning. BUG=417463 TBR=stip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627163002/1
6 years, 2 months ago (2014-10-04 06:44:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 292319
6 years, 2 months ago (2014-10-04 06:47:10 UTC) #4
dcheng
6 years, 2 months ago (2014-10-04 06:48:28 UTC) #5
Message was sent while issue was closed.
(Sorry thought I hit the mail button before hitting commit.)

FYI.

Powered by Google App Engine
This is Rietveld 408576698