Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 62713006: Runtime CHECK for overflow in NewTypedArray. (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Runtime CHECK for overflow in NewTypedArray. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/api.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-14 09:09:08 UTC) #1
ulan
LGTM if this check guards against breaking precondition of NewTypedArray, i.e. if we expect the ...
7 years, 1 month ago (2013-11-14 09:23:47 UTC) #2
Dmitry Lomov (no reviews)
On 2013/11/14 09:23:47, ulan wrote: > LGTM if this check guards against breaking precondition of ...
7 years, 1 month ago (2013-11-14 09:42:33 UTC) #3
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-14 11:52:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698