Move ExtensionProcessManager to src/extensions, part 4

Move ExtensionProcessManager to src/extensions, part 4

* Move c/b/extensions/extension_process_manager.h to
  extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace

BUG=313481
TEST=browser_tests, unit_tests
R=miket@chromium.org
TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233956

[James Cook, 2013-11-07 00:30:51]

miket, PTAL

This is mostly a mechanical change. The most interesting bits to review are the
changes to extensions/browser/DEPS and the changes inside
extensions/browser/process_manager.h/cc

I'm intentionally leaving the unit and browser tests in Chrome -- we discussed
that at our meeting and it seems like a reasonable thing to do.  The unit tests
in particular can move down later when more of the system is ported.

[James Cook, 2013-11-07 17:34:56]

https://codereview.chromium.org/62713003/diff/80001/extensions/browser/DEPS
File extensions/browser/DEPS (left):

https://codereview.chromium.org/62713003/diff/80001/extensions/browser/DEPS#o...
extensions/browser/DEPS:12:
"+chrome/browser/extensions/extension_process_manager.h",
One big one down at the cost of three small ones added.  yoz is close to
finishing extension_host.h and I'll have background_info.h below done shortly.

[miket_OOO, 2013-11-07 20:24:51]

One nit, rest LGTM!

https://codereview.chromium.org/62713003/diff/80001/apps/launcher.cc
File apps/launcher.cc (right):

https://codereview.chromium.org/62713003/diff/80001/apps/launcher.cc#newcode62
apps/launcher.cc:62: //jamesdebug
Remove me!

https://codereview.chromium.org/62713003/diff/80001/extensions/browser/DEPS
File extensions/browser/DEPS (left):

https://codereview.chromium.org/62713003/diff/80001/extensions/browser/DEPS#o...
extensions/browser/DEPS:12:
"+chrome/browser/extensions/extension_process_manager.h",
On 2013/11/07 17:34:56, James Cook wrote:
> One big one down at the cost of three small ones added.  yoz is close to
> finishing extension_host.h and I'll have background_info.h below done shortly.

Cool!

[commit-bot: I haz the power, 2013-11-07 21:03:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/62713003/140001

[commit-bot: I haz the power, 2013-11-07 21:04:07]

Failed to apply patch for chrome/browser/task_manager/task_manager.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/task_manager/task_manager.cc
  Hunk #3 FAILED at 157.
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/task_manager/task_manager.cc.rej

Patch:       chrome/browser/task_manager/task_manager.cc
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc
b/chrome/browser/task_manager/task_manager.cc
index
b062ec61444ec07adfed2cc7a063dd7af395347e..7786948e24960a729f434a03153a6410191c7489
100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -16,7 +16,6 @@
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
-#include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/task_manager/background_resource_provider.h"
@@ -39,6 +38,7 @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/result_codes.h"
+#include "extensions/browser/process_manager.h"
 #include "grit/generated_resources.h"
 #include "grit/ui_resources.h"
 #include "third_party/icu/source/i18n/unicode/coll.h"
@@ -157,15 +157,17 @@ void GetWinUSERHandles(base::ProcessHandle process,
 // Counts the number of extension background pages associated with this
profile.
 int CountExtensionBackgroundPagesForProfile(Profile* profile) {
   int count = 0;
-  ExtensionProcessManager* manager =
+  extensions::ProcessManager* manager =
       extensions::ExtensionSystem::Get(profile)->process_manager();
   if (!manager)
     return count;
 
-  const ExtensionProcessManager::ExtensionHostSet& background_hosts =
+  const extensions::ProcessManager::ExtensionHostSet& background_hosts =
       manager->background_hosts();
-  for (ExtensionProcessManager::const_iterator iter = background_hosts.begin();
-       iter != background_hosts.end(); ++iter) {
+  for (extensions::ProcessManager::const_iterator iter =
+           background_hosts.begin();
+       iter != background_hosts.end();
+       ++iter) {
     ++count;
   }
   return count;

[commit-bot: I haz the power, 2013-11-07 21:42:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/62713003/160002

[commit-bot: I haz the power, 2013-11-08 07:43:19]

Failed to apply patch for chrome/browser/policy/policy_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/policy/policy_browsertest.cc
  Hunk #2 FAILED at 113.
  Hunk #3 succeeded at 1554 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/policy/policy_browsertest.cc.rej

Patch:       chrome/browser/policy/policy_browsertest.cc
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc
b/chrome/browser/policy/policy_browsertest.cc
index
541055095820e7b6eec486f1204a07f7593e4e41..03d898b08cb312eaee4fcfc789db8bc86de012f6
100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -35,7 +35,6 @@
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_host.h"
-#include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
@@ -114,6 +113,7 @@
 #include "content/public/test/test_utils.h"
 #include "content/test/net/url_request_failed_job.h"
 #include "content/test/net/url_request_mock_http_job.h"
+#include "extensions/browser/process_manager.h"
 #include "grit/generated_resources.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
@@ -1554,10 +1554,10 @@ IN_PROC_BROWSER_TEST_F(PolicyTest,
ExtensionInstallForcelist) {
 
   // Wait until any background pages belonging to force-installed extensions
   // have been loaded.
-  ExtensionProcessManager* manager =
+  extensions::ProcessManager* manager =
      
extensions::ExtensionSystem::Get(browser()->profile())->process_manager();
-  ExtensionProcessManager::ViewSet all_views = manager->GetAllViews();
-  for (ExtensionProcessManager::ViewSet::const_iterator iter =
+  extensions::ProcessManager::ViewSet all_views = manager->GetAllViews();
+  for (extensions::ProcessManager::ViewSet::const_iterator iter =
            all_views.begin();
        iter != all_views.end();) {
     if (!(*iter)->IsLoading()) {

[James Cook, 2013-11-08 19:15:27]

Committed patchset #6 manually as r233956 (presubmit successful).

[James Cook, 2013-11-08 19:54:19]

On 2013/11/08 19:15:27, James Cook wrote:
> Committed patchset #6 manually as r233956 (presubmit successful).

Reverted at http://src.chromium.org/viewvc/chrome?view=rev&revision=233959

Broke compile on the official chromeos builder (but not the regular builders
!?!). 
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chro...

[James Cook, 2013-11-08 22:24:24]

On 2013/11/08 19:54:19, James Cook wrote:
> On 2013/11/08 19:15:27, James Cook wrote:
> > Committed patchset #6 manually as r233956 (presubmit successful).
> 
> Reverted at http://src.chromium.org/viewvc/chrome?view=rev&revision=233959
> 
> Broke compile on the official chromeos builder (but not the regular builders
> !?!). 
>
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%2520Ch...

Attempt to reland: https://codereview.chromium.org/67253003/