Issue 62713002: Revert "BMM: Split initialization into two phases"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62713002: Revert "BMM: Split initialization into two phases" (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
arv (Not doing code reviews), Elliot Glaysher, Dan Beam

CC:
chromium-reviews, tfarina, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "BMM: Split initialization into two phases" This reverts commit 31f458db9954f50977e1e966f3237c838b20f083. Revert "Update command state on "load" of a folder" This reverts commit 778b807f33551529c3da5bb5a30eddee8d2c61ab. These caused the browser_test BookmarksTest.CommandOpensBookmarksTab to hang on Linux Aura. BUG=312356, 313592, 315408 TBR=arv@chromium.org,dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233314

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -29 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/js/main.js	View		7 chunks	+27 lines, -29 lines	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

7 years, 1 month ago (2013-11-06 18:57:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r233314 (presubmit successful).