Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 627103005: Unrolls array initialization loop for small arrays. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 40940)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -1920,6 +1920,7 @@
intptr_t num_elements,
Label* slow_path,
Label* done) {
+ const int kInlineArraySize = 12; // Same as kInlineInstanceSize.
const Register kLengthReg = R10;
const Register kElemTypeReg = RBX;
const intptr_t instance_size = Array::InstanceSize(num_elements);
@@ -1945,14 +1946,23 @@
// RDI: iterator which initially points to the start of the variable
// data area to be initialized.
if (num_elements > 0) {
+ const intptr_t array_size = instance_size - sizeof(RawArray);
__ LoadObject(R12, Object::null_object(), PP);
__ leaq(RDI, FieldAddress(RAX, sizeof(RawArray)));
- Label init_loop;
- __ Bind(&init_loop);
- __ movq(Address(RDI, 0), R12);
- __ addq(RDI, Immediate(kWordSize));
- __ cmpq(RDI, RCX);
- __ j(BELOW, &init_loop, Assembler::kNearJump);
+ if (array_size < (kInlineArraySize * kWordSize)) {
+ intptr_t current_offset = 0;
+ while (current_offset < array_size) {
+ __ movq(Address(RDI, current_offset), R12);
+ current_offset += kWordSize;
+ }
+ } else {
+ Label init_loop;
+ __ Bind(&init_loop);
+ __ movq(Address(RDI, 0), R12);
+ __ addq(RDI, Immediate(kWordSize));
+ __ cmpq(RDI, RCX);
+ __ j(BELOW, &init_loop, Assembler::kNearJump);
+ }
}
__ jmp(done, Assembler::kNearJump);
}
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698