Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 627103005: Unrolls array initialization loop for small arrays. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 40940)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -2062,6 +2062,7 @@
intptr_t num_elements,
Label* slow_path,
Label* done) {
+ const int kInlineArraySize = 12; // Same as kInlineInstanceSize.
const Register kLengthReg = EDX;
const Register kElemTypeReg = ECX;
const intptr_t instance_size = Array::InstanceSize(num_elements);
@@ -2088,15 +2089,25 @@
// EDI: iterator which initially points to the start of the variable
// data area to be initialized.
if (num_elements > 0) {
+ const intptr_t array_size = instance_size - sizeof(RawArray);
const Immediate& raw_null =
Immediate(reinterpret_cast<intptr_t>(Object::null()));
__ leal(EDI, FieldAddress(EAX, sizeof(RawArray)));
- Label init_loop;
- __ Bind(&init_loop);
- __ movl(Address(EDI, 0), raw_null);
- __ addl(EDI, Immediate(kWordSize));
- __ cmpl(EDI, EBX);
- __ j(BELOW, &init_loop, Assembler::kNearJump);
+ if (array_size < (kInlineArraySize * kWordSize)) {
+ intptr_t current_offset = 0;
+ __ movl(EBX, raw_null);
+ while (current_offset < array_size) {
+ __ movl(Address(EDI, current_offset), EBX);
+ current_offset += kWordSize;
+ }
+ } else {
+ Label init_loop;
+ __ Bind(&init_loop);
+ __ movl(Address(EDI, 0), raw_null);
+ __ addl(EDI, Immediate(kWordSize));
+ __ cmpl(EDI, EBX);
+ __ j(BELOW, &init_loop, Assembler::kNearJump);
+ }
}
__ jmp(done, Assembler::kNearJump);
}
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698