Issue 627103003: Add shared library version of libcli_main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 627103003: Add shared library version of libcli_main

Created:
6 years, 2 months ago by Sam Clegg

Modified:
6 years, 2 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com, Sam Clegg

Base URL:
https://chromium.googlesource.com/external/naclports.git@master

Visibility:
Public.

More Reviews

Description

Add shared library version of libcli_main Also put nacl-spawn include files in thier own folder (this avoid the include_next warning from the pnacl compiler). BUG=

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -326 lines)			Patch
M	build_tools/common.sh	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ports/nacl-spawn/Makefile	View		2 chunks	+5 lines, -2 lines	0 comments	Download
D	ports/nacl-spawn/bsd_spawn.h	View		1 chunk	+0 lines, -129 lines	0 comments	Download
M	ports/nacl-spawn/build.sh	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
D	ports/nacl-spawn/elf_reader.h	View		1 chunk	+0 lines, -45 lines	0 comments	Download
M	ports/nacl-spawn/elf_reader.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	ports/nacl-spawn/include/bsd_spawn.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ports/nacl-spawn/include/elf_reader.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ports/nacl-spawn/include/library_dependencies.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ports/nacl-spawn/include/nacl_main.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ports/nacl-spawn/include/path_util.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ports/nacl-spawn/include/spawn.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ports/nacl-spawn/library_dependencies.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	ports/nacl-spawn/nacl_main.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	ports/nacl-spawn/nacl_spawn.cc	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
D	ports/nacl-spawn/path_util.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	ports/nacl-spawn/spawn.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download