Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 627093002: mojo_js_standalone will quit after the last JSApp quits (Closed)

Created:
6 years, 2 months ago by hansmuller
Modified:
6 years, 2 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo_js_standalone will quit after the last JSApp quits I've also changed mojo_shell so that extra spaces in between app configuration arguments aren't turned into empty strings. BUG=420243 Committed: https://crrev.com/b5334e7a527563ab6e96704325f8b5d53d8d791c Cr-Commit-Position: refs/heads/master@{#298917}

Patch Set 1 #

Patch Set 2 : Attempt to fix the inexplicable fail-to-commit with a resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M mojo/apps/js/application_delegate_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/apps/js/js_app.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
hansmuller
This is a micro-change. PTAL.
6 years, 2 months ago (2014-10-03 23:47:44 UTC) #2
Aaron Boodman
lgtm
6 years, 2 months ago (2014-10-04 02:14:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627093002/1
6 years, 2 months ago (2014-10-08 19:27:56 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 01:33:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627093002/1
6 years, 2 months ago (2014-10-09 14:26:20 UTC) #9
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 14:46:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627093002/1
6 years, 2 months ago (2014-10-09 14:49:33 UTC) #14
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 14:51:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627093002/1
6 years, 2 months ago (2014-10-09 15:16:40 UTC) #19
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 15:18:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627093002/20001
6 years, 2 months ago (2014-10-09 16:40:31 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-09 17:08:17 UTC) #25
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:09:12 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5334e7a527563ab6e96704325f8b5d53d8d791c
Cr-Commit-Position: refs/heads/master@{#298917}

Powered by Google App Engine
This is Rietveld 408576698