Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 627003004: Add supportedOS GUID for Windows 10 (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add supportedOS GUID for Windows 10 R=grt@chromium.org BUG=420629 Committed: https://crrev.com/c5b4ba478cb54f9bd07edb34bb965c1aac246b36 Cr-Commit-Position: refs/heads/master@{#298339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/win/compatibility.manifest View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.exe.manifest View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
scottmg
6 years, 2 months ago (2014-10-06 18:02:34 UTC) #2
grt (UTC plus 2)
lgtm
6 years, 2 months ago (2014-10-06 19:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627003004/1
6 years, 2 months ago (2014-10-06 19:39:06 UTC) #5
scottmg
Hmm, 'analyze' is being too aggressive here. I'll file a bug.
6 years, 2 months ago (2014-10-06 19:44:30 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 01:28:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627003004/1
6 years, 2 months ago (2014-10-07 01:55:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5e191f0a46f94c6f07a708bfababbf341282c515
6 years, 2 months ago (2014-10-07 02:49:23 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:50:54 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c5b4ba478cb54f9bd07edb34bb965c1aac246b36
Cr-Commit-Position: refs/heads/master@{#298339}

Powered by Google App Engine
This is Rietveld 408576698