Issue 626973002: Remove the old Web Notification code-path (Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 626973002: Remove the old Web Notification code-path (Chromium) (Closed)

Created:
6 years, 2 months ago by Peter Beverloo

Modified:
6 years, 1 month ago

Reviewers:

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove the old Web Notification code-path (Chromium) This patch removes the old Web Notifications code-path now that we've switched to the new Workers-enabled path. BUG=392187

Patch Set 1 #

Patch Set 2 : browser tests pass #

Patch Set 3 : layout tests pass #

Patch Set 4 : rebase #

Patch Set 5 : Rebase + more tests #

Patch Set 6 : new layout tests pass #

Patch Set 7 : rebase #

Patch Set 8 : moar changes #

Patch Set 9 : current state #

Patch Set 10 : rebase #

Patch Set 11 : rebase #

Patch Set 12 : rebase #

Patch Set 13 : rebase again #

Patch Set 14 : #

Patch Set 15 : rebase #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -898 lines)			Patch
M	content/browser/frame_host/render_frame_host_impl.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	4 chunks	+0 lines, -81 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1 2 3 4 5 6 7 8 9 10 11	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/content_renderer.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	3 chunks	+0 lines, -12 lines	0 comments	Download
M	content/content_shell.gypi	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+0 lines, -2 lines	0 comments	Download
D	content/renderer/active_notification_tracker.h	View		1 chunk	+0 lines, -47 lines	0 comments	Download
D	content/renderer/active_notification_tracker.cc	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	content/renderer/active_notification_tracker_unittest.cc	View		1 chunk	+0 lines, -29 lines	0 comments	Download
D	content/renderer/notification_icon_loader.h	View	1 2 3 4 5 13	1 chunk	+0 lines, -73 lines	0 comments	Download
D	content/renderer/notification_icon_loader.cc	View	1 2 3 4 5 13	1 chunk	+0 lines, -83 lines	0 comments	Download
D	content/renderer/notification_provider.h	View	1 2 3 4 5 6 7 8 9 10 11 13	1 chunk	+0 lines, -66 lines	0 comments	Download
D	content/renderer/notification_provider.cc	View	1 2 3 4 5 6 7 8 9 10 11 13	1 chunk	+0 lines, -165 lines	0 comments	Download
M	content/renderer/render_frame_impl.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	4 chunks	+0 lines, -7 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	4 chunks	+0 lines, -10 lines	0 comments	Download
M	content/shell/browser/layout_test/layout_test_message_filter.h	View	1 2 3 4 5 6 7 8	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/shell/browser/layout_test/layout_test_message_filter.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+0 lines, -12 lines	0 comments	Download
M	content/shell/common/layout_test/layout_test_messages.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/renderer/layout_test/webkit_test_runner.h	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/shell/renderer/layout_test/webkit_test_runner.cc	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+0 lines, -10 lines	0 comments	Download
D	content/shell/renderer/test_runner/notification_presenter.h	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	content/shell/renderer/test_runner/notification_presenter.cc	View		1 chunk	+0 lines, -133 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_runner.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	5 chunks	+1 line, -6 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_runner.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	6 chunks	+0 lines, -12 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_frame_test_proxy.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_delegate.h	View	1 2 3 4 5 6 7 8 9 10 11	2 chunks	+1 line, -4 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_proxy.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -4 lines	0 comments	Download