Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 626913003: Remove unused code in AppActivityProxy (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused code in AppActivityProxy BUG=None TEST=None Committed: https://crrev.com/e1cfa8469e59a23f68eeadae32c4f78cc89296cb Cr-Commit-Position: refs/heads/master@{#299111}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M athena/content/app_activity_proxy.cc View 2 chunks +0 lines, -5 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
pkotwicz
Stefan, PTAL. I believe that this is no longer necessary as a result of https://codereview.chromium.org/596623005
6 years, 2 months ago (2014-10-03 21:42:26 UTC) #3
Mr4D (OOO till 08-26)
https://codereview.chromium.org/626913003/diff/40001/athena/content/app_activity_proxy.cc File athena/content/app_activity_proxy.cc (left): https://codereview.chromium.org/626913003/diff/40001/athena/content/app_activity_proxy.cc#oldcode75 athena/content/app_activity_proxy.cc:75: wm::ActivateWindow(window_list_provider->GetWindowList().back()); Are you sure this works now as intended? ...
6 years, 2 months ago (2014-10-03 23:26:18 UTC) #5
pkotwicz
Ping?
6 years, 2 months ago (2014-10-08 02:20:07 UTC) #6
Mr4D (OOO till 08-26)
I have sent out the browser tests today and await their review. I will test ...
6 years, 2 months ago (2014-10-08 03:48:00 UTC) #7
Mr4D (OOO till 08-26)
lgtm With my upcoming change (CL 631333003) these lines can go. However in its current ...
6 years, 2 months ago (2014-10-08 14:06:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626913003/40001
6 years, 2 months ago (2014-10-10 14:03:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years, 2 months ago (2014-10-10 14:43:12 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 14:43:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1cfa8469e59a23f68eeadae32c4f78cc89296cb
Cr-Commit-Position: refs/heads/master@{#299111}

Powered by Google App Engine
This is Rietveld 408576698