Issue 626813002: Files.app: Move updateLocationLine function from FileManager class to the UI class.

Issue 626813002: Files.app: Move updateLocationLine function from FileManager class to the UI class. (Closed)

Created:
6 years, 2 months ago by hirono

Modified:
6 years, 2 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Files.app: Move updateLocationLine function from FileManager class to the UI class. BUG=267281 TEST=None Committed: https://crrev.com/ab9bcceae44e1c2e02baa39e041117f03daa1291 Cr-Commit-Position: refs/heads/master@{#298016}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/file_manager.js	View		3 chunks	+5 lines, -27 lines	0 comments	Download
	M	ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js	View	1	2 chunks	+23 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

hirono

PTAL the CL? This is the first patch to reduce the lines of file_manager.js.

6 years, 2 months ago (2014-10-03 07:53:27 UTC) #2

fukino

On 2014/10/03 07:53:27, hirono wrote: > PTAL the CL? > This is the first patch ...

6 years, 2 months ago (2014-10-03 07:59:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626813002/20001

6 years, 2 months ago (2014-10-03 09:08:47 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 119dab40ba914ff92c826e6236724d2715e56feb

6 years, 2 months ago (2014-10-03 09:32:58 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-03 09:33:37 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/ab9bcceae44e1c2e02baa39e041117f03daa1291
Cr-Commit-Position: refs/heads/master@{#298016}