Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 626803002: Introduce WebDataConsumerHandle. (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce WebDataConsumerHandle. Define an abstract class which whose implementation will be in content/renderer. This class is used by fetch API with Streams. BUG=418879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184493

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A public/platform/WebDataConsumerHandle.h View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
yhirano
Chromium side CL: https://codereview.chromium.org/620303002/
6 years, 2 months ago (2014-10-03 07:51:28 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/626803002/diff/1/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/1/public/platform/WebDataConsumerHandle.h#newcode23 public/platform/WebDataConsumerHandle.h:23: using Flags = unsigned; say that this corresponds to ...
6 years, 2 months ago (2014-10-06 16:12:25 UTC) #3
yhirano
https://codereview.chromium.org/626803002/diff/1/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/1/public/platform/WebDataConsumerHandle.h#newcode23 public/platform/WebDataConsumerHandle.h:23: using Flags = unsigned; On 2014/10/06 16:12:25, tyoshino wrote: ...
6 years, 2 months ago (2014-10-07 02:28:12 UTC) #4
yhirano
ping
6 years, 2 months ago (2014-10-16 06:47:46 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/626803002/diff/20001/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/20001/public/platform/WebDataConsumerHandle.h#newcode46 public/platform/WebDataConsumerHandle.h:46: // Reads data into |data| upto |size| bytes. ...
6 years, 2 months ago (2014-10-16 07:25:31 UTC) #6
yhirano
+tkent for OWNER review. https://codereview.chromium.org/626803002/diff/20001/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/20001/public/platform/WebDataConsumerHandle.h#newcode46 public/platform/WebDataConsumerHandle.h:46: // Reads data into |data| ...
6 years, 2 months ago (2014-10-17 02:03:26 UTC) #8
tkent
lgtm https://codereview.chromium.org/626803002/diff/40001/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/40001/public/platform/WebDataConsumerHandle.h#newcode8 public/platform/WebDataConsumerHandle.h:8: #include <stdlib.h> nit: I guess you add stdlib.h ...
6 years, 2 months ago (2014-10-17 02:23:07 UTC) #9
yhirano
https://codereview.chromium.org/626803002/diff/40001/public/platform/WebDataConsumerHandle.h File public/platform/WebDataConsumerHandle.h (right): https://codereview.chromium.org/626803002/diff/40001/public/platform/WebDataConsumerHandle.h#newcode8 public/platform/WebDataConsumerHandle.h:8: #include <stdlib.h> On 2014/10/17 02:23:07, tkent wrote: > nit: ...
6 years, 2 months ago (2014-10-17 03:40:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626803002/80001
6 years, 1 month ago (2014-10-28 01:36:48 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 03:16:13 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 184493

Powered by Google App Engine
This is Rietveld 408576698