Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 626633002: Convert a couple loops to range based iterators. (Closed)

Created:
6 years, 2 months ago by Zachary Kuznia
Modified:
6 years, 2 months ago
Reviewers:
achuithb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert a couple loops to range based iterators. BUG=None Committed: https://crrev.com/ba1aa68e3db415a56c2d16e3183c5ffa0a3ddcc3 Cr-Commit-Position: refs/heads/master@{#297940}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M components/pairing/bluetooth_controller_pairing_controller.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/pairing/fake_controller_pairing_controller.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Zachary Kuznia
6 years, 2 months ago (2014-10-02 21:02:51 UTC) #2
achuithb
lgtm with a requested fix. https://codereview.chromium.org/626633002/diff/1/components/pairing/fake_controller_pairing_controller.cc File components/pairing/fake_controller_pairing_controller.cc (right): https://codereview.chromium.org/626633002/diff/1/components/pairing/fake_controller_pairing_controller.cc#newcode86 components/pairing/fake_controller_pairing_controller.cc:86: std::string type = event.first; ...
6 years, 2 months ago (2014-10-02 21:09:55 UTC) #3
Zachary Kuznia
https://codereview.chromium.org/626633002/diff/1/components/pairing/fake_controller_pairing_controller.cc File components/pairing/fake_controller_pairing_controller.cc (right): https://codereview.chromium.org/626633002/diff/1/components/pairing/fake_controller_pairing_controller.cc#newcode86 components/pairing/fake_controller_pairing_controller.cc:86: std::string type = event.first; On 2014/10/02 21:09:54, achuithb wrote: ...
6 years, 2 months ago (2014-10-02 21:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626633002/20001
6 years, 2 months ago (2014-10-02 21:26:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6655d54e573349643a2b1d562dfa54ea69046950
6 years, 2 months ago (2014-10-02 23:03:16 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:05:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba1aa68e3db415a56c2d16e3183c5ffa0a3ddcc3
Cr-Commit-Position: refs/heads/master@{#297940}

Powered by Google App Engine
This is Rietveld 408576698