src/pdf/SkPDFFont.h - Issue 626613002: Fix int16_t for glyphs, const glyphs, and clarify glyph loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFFont.h

Issue 626613002: Fix int16_t for glyphs, const glyphs, and clarify glyph loop. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFFont.h

diff --git a/src/pdf/SkPDFFont.h b/src/pdf/SkPDFFont.h

index 48d9c30b815f500bc3c4d7538f00bc70f9fbcda4..27f1b5bfe3c35e169b1be72d2fca30516f32460d 100644

--- a/src/pdf/SkPDFFont.h

+++ b/src/pdf/SkPDFFont.h

@@ -164,7 +164,7 @@ protected:

/** Set fFirstGlyphID and fLastGlyphID to span at most 255 glyphs,

* including the passed glyphID.

- void adjustGlyphRangeForSingleByteEncoding(int16_t glyphID);

+ void adjustGlyphRangeForSingleByteEncoding(uint16_t glyphID);

// Generate ToUnicode table according to glyph usage subset.

// If subset is NULL, all available glyph ids will be used.

« no previous file with comments | « src/pdf/SkPDFDevice.cpp ('k') | src/pdf/SkPDFFont.cpp » ('j') | no next file with comments »