src/pdf/SkPDFFontImpl.h - Issue 626613002: Fix int16_t for glyphs, const glyphs, and clarify glyph loop.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/pdf/SkPDFFontImpl.h

Issue 626613002: Fix int16_t for glyphs, const glyphs, and clarify glyph loop. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright 2011 Google Inc.	3 * Copyright 2011 Google Inc.

4 *	4 *

5 * Use of this source code is governed by a BSD-style license that can be	5 * Use of this source code is governed by a BSD-style license that can be

6 * found in the LICENSE file.	6 * found in the LICENSE file.

7 */	7 */

8	8

9	9

10 #ifndef SkPDFFontImpl_DEFINED	10 #ifndef SkPDFFontImpl_DEFINED

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 public:	71 public:

72 virtual ~SkPDFType3Font();	72 virtual ~SkPDFType3Font();

73 virtual bool multiByteGlyphs() const { return false; }	73 virtual bool multiByteGlyphs() const { return false; }

74	74

75 private:	75 private:

76 friend class SkPDFFont; // to access the constructor	76 friend class SkPDFFont; // to access the constructor

77	77

78 SkPDFType3Font(const SkAdvancedTypefaceMetrics* info,	78 SkPDFType3Font(const SkAdvancedTypefaceMetrics* info,

79 SkTypeface* typeface, uint16_t glyphID);	79 SkTypeface* typeface, uint16_t glyphID);

80	80

81 bool populate(int16_t glyphID);	81 bool populate(uint16_t glyphID);

82 };	82 };

83	83

84 #endif	84 #endif

OLD	NEW

« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | no next file » | no next file with comments »