Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 626583002: specialize setConcat for scale+translate (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

specialize setConcat for scale+translate This reverts commit 2a382f519999109b2e3445e73ddb4f0eae926b51. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d1f0ebd0e237c74876f780126696daed9d63f80b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -41 lines) Patch
M include/core/SkMatrix.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/core/SkMatrix.cpp View 9 chunks +21 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
needs to follow the patch to nanobench
6 years, 2 months ago (2014-10-02 19:45:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626583002/1
6 years, 2 months ago (2014-10-02 19:45:40 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 19:45:41 UTC) #5
robertphillips
lgtm
6 years, 2 months ago (2014-10-02 19:48:13 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:58:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d1f0ebd0e237c74876f780126696daed9d63f80b

Powered by Google App Engine
This is Rietveld 408576698