[Search] Modify the First-run experience in Landscape mode

[Search] Modify the First-run experience in Landscape mode

BUG=None

Committed: https://crrev.com/b600c161a8e6568e18b0886c0eb82fb2f06d8d4c
Cr-Commit-Position: refs/heads/master@{#297877}

[Mathieu, 2014-10-02 14:41:50]

mathp@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[Mathieu, 2014-10-02 14:42:07]

Hi Pedro, 

This is the implementation related to the email I sent you.

[pedro (no code reviews), 2014-10-02 18:19:42]

lgtm

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:27: text-align: right;
text-align: end (to make it RTL friendly)

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:77: float: left;
Add RTL support?

html[dir="rtl"] .landscape {
  float: right;
}

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.html (right):

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.html:16: <img id="header-image"
class="portrait" src="header.svg">
Nit: It would be nice if there was just a single <img>, but that might not be
easy to accomplish with CSS. Don't bother if it doesn't work.

[Mathieu, 2014-10-02 18:25:43]

mathp@chromium.org changed reviewers:
+ huangs@chromium.org

[Mathieu, 2014-10-02 18:25:55]

Thanks, Sam, can you PTAL?

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:27: text-align: right;
On 2014/10/02 18:19:42, pedrosimonetti wrote:
> text-align: end (to make it RTL friendly)

Done.

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:27: text-align: right;
On 2014/10/02 18:19:42, pedrosimonetti wrote:
> text-align: end (to make it RTL friendly)

Done.

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:77: float: left;
On 2014/10/02 18:19:42, pedrosimonetti wrote:
> Add RTL support?
> 
> html[dir="rtl"] .landscape {
>   float: right;
> }

Done.

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.html (right):

https://codereview.chromium.org/626513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.html:16: <img id="header-image"
class="portrait" src="header.svg">
On 2014/10/02 18:19:42, pedrosimonetti wrote:
> Nit: It would be nice if there was just a single <img>, but that might not be
> easy to accomplish with CSS. Don't bother if it doesn't work.

Acknowledged.

[huangs, 2014-10-02 18:29:33]

lgtm

https://codereview.chromium.org/626513002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/626513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:59: 
NIT: Remove spaces between #heading, #header-image, .portrait, .landscape , to
match contents in the @media.

[Mathieu, 2014-10-02 18:40:10]

Thanks, submitting

https://codereview.chromium.org/626513002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.css (right):

https://codereview.chromium.org/626513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.css:59: 
On 2014/10/02 18:29:33, huangs1 wrote:
> NIT: Remove spaces between #heading, #header-image, .portrait, .landscape , to
> match contents in the @media.

Done.

[Mathieu, 2014-10-02 18:41:59]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-10-02 18:42:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/626513002/60001

[commit-bot: I haz the power, 2014-10-02 19:15:09]

Committed patchset #4 (id:60001) as 6d5691d6306d32e21a46831ce6add52f63a3dd98

[commit-bot: I haz the power, 2014-10-02 19:16:15]

Patchset 4 (id:??) landed as
https://crrev.com/b600c161a8e6568e18b0886c0eb82fb2f06d8d4c
Cr-Commit-Position: refs/heads/master@{#297877}