Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 626503002: [athena] Various fixes for out-of-box/login (Closed)

Created:
6 years, 2 months ago by Nikita (slow)
Modified:
6 years, 2 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[athena] Various fixes for out-of-box/login * Add unused parameter for toggling spoken feedback handler * For Athena disable magnification, use proper shutdown API BUG=419708 Committed: https://crrev.com/28f316ee604a7bf7e6d7f1aa588bc7da37c7d529 Cr-Commit-Position: refs/heads/master@{#297842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nikita (slow)
6 years, 2 months ago (2014-10-02 14:18:45 UTC) #2
Dmitry Polukhin
lgtm
6 years, 2 months ago (2014-10-02 14:36:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626503002/1
6 years, 2 months ago (2014-10-02 15:09:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6012e39535dd69e1b6f837c3e73580a9ca98f173
6 years, 2 months ago (2014-10-02 15:46:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 15:47:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/28f316ee604a7bf7e6d7f1aa588bc7da37c7d529
Cr-Commit-Position: refs/heads/master@{#297842}

Powered by Google App Engine
This is Rietveld 408576698