Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: tests/toolchain/nacl.scons

Issue 62643002: Deploy new x86 binutils (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: add TODO comment; disable ncval-using test when using old ncval Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_ragel/testdata/64/legacy.test ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/toolchain/nacl.scons
diff --git a/tests/toolchain/nacl.scons b/tests/toolchain/nacl.scons
index 7848df2c0f51c5611503fbba562fbb97055791bf..191b0e53e2e0717bfa29b747a3725e669e0bf519 100644
--- a/tests/toolchain/nacl.scons
+++ b/tests/toolchain/nacl.scons
@@ -46,7 +46,14 @@ node = env.CommandValidatorTestNacl('whole_archive_test.out',
image=nexe)
env.AddNodeToTestSuite(node,
['toolchain_tests', 'small_tests'],
- 'run_whole_archive_test')
+ 'run_whole_archive_test',
+ # The old ncval doesn't like the new linker's style
+ # of padding the code segment. TODO(mcgrathr):
+ # Remove this is_broken= when we the old ncval is no
+ # longer ever built and used for this test.
+ is_broken=(env.IsNewLinker() and
+ env.Bit('target_x86') and
+ not env.Bit('validator_ragel')))
def AddIntrinsicTest(test_env, src, exit_status,
« no previous file with comments | « src/trusted/validator_ragel/testdata/64/legacy.test ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698