Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: SConstruct

Issue 62643002: Deploy new x86 binutils (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: add TODO comment; disable ncval-using test when using old ncval Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | TOOL_REVISIONS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 450371f9b1161d8a10d92b197152cf358dd416d6..6b7fee48a3119e3f6c560d3bd5b181c4793988ae 100755
--- a/SConstruct
+++ b/SConstruct
@@ -2736,10 +2736,11 @@ nacl_env = MakeArchSpecificEnv().Clone(
LIST_MAPPINGS_LIBS = ['nacl_list_mappings_private'],
)
+# TODO(mcgrathr): Remove this after the new binutils has settled.
def IsNewLinker(env):
"""Return True if using a new-style linker with the new-style layout.
That means the linker supports the -Trodata-segment switch."""
- return env.Bit('target_arm') or env.Bit('bitcode')
+ return True
nacl_env.AddMethod(IsNewLinker)
@@ -3005,9 +3006,9 @@ nacl_env.Replace(PPAPI_LIBS=['ppapi'])
# See http://code.google.com/p/nativeclient/issues/detail?id=1298
def GetLinkerScriptBaseName(env):
if env.Bit('build_x86_64'):
- return 'elf64_nacl'
+ return 'elf_x86_64_nacl'
else:
- return 'elf_nacl'
+ return 'elf_i386_nacl'
if (nacl_env.Bit('nacl_glibc') and
nacl_env.Bit('nacl_static_link')):
« no previous file with comments | « no previous file | TOOL_REVISIONS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698