Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 626403003: Respect user_scrollable disabling in pinch-virtual-viewport mode. (Closed)

Created:
6 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 2 months ago
Reviewers:
bokan
CC:
cc-bugs_chromium.org, chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Respect user_scrollable disabling in pinch-virtual-viewport mode. user_scrollable_x/y are used to suppress impl-side scrolling when the page specifies overflow: hidden. This has been disabled for a while because of poor interaction with pinch zoom. In the new pinch-virtual model, this works better (outer viewport doesn't scroll so that the user can't see parts of the page not intended to be seen, but pinch zooming and moving around still works), so re-enable it when that setting is active. Note that I'm also planning to start using this for disabling scrolling for fullscreen elements. BUG=322223, 175502, 411072 Committed: https://crrev.com/af915a887e3ec61eb029822ac7577a9198628935 Cr-Commit-Position: refs/heads/master@{#299428}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M cc/layers/layer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
aelias_OOO_until_Jul13
Hi bokan@, PTAL. This is useful for fullscreen video anyway so I thought I'd fix ...
6 years, 2 months ago (2014-10-07 22:27:43 UTC) #2
bokan
lgtm, exciting that overflow: hidden will finally work correctly :)
6 years, 2 months ago (2014-10-08 15:24:13 UTC) #3
Rick Byers
On 2014/10/08 15:24:13, bokan wrote: > lgtm, exciting that overflow: hidden will finally work correctly ...
6 years, 2 months ago (2014-10-08 16:53:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626403003/20001
6 years, 2 months ago (2014-10-08 19:48:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16428)
6 years, 2 months ago (2014-10-08 20:42:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626403003/20001
6 years, 2 months ago (2014-10-14 03:44:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-14 04:12:13 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 04:13:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af915a887e3ec61eb029822ac7577a9198628935
Cr-Commit-Position: refs/heads/master@{#299428}

Powered by Google App Engine
This is Rietveld 408576698