Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4070)

Unified Diff: chrome/browser/extensions/key_identifier_conversion_views.h

Issue 6264020: Fix key identifier conversion. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/key_identifier_conversion_views.h
diff --git a/ui/base/keycodes/keyboard_code_conversion.h b/chrome/browser/extensions/key_identifier_conversion_views.h
similarity index 51%
rename from ui/base/keycodes/keyboard_code_conversion.h
rename to chrome/browser/extensions/key_identifier_conversion_views.h
index a7a833171490d18ec8144e9362ae82b315ae86d3..29a1f16d7a8e2d5fd588dfe347d5f469fdaf4d54 100644
--- a/ui/base/keycodes/keyboard_code_conversion.h
+++ b/chrome/browser/extensions/key_identifier_conversion_views.h
@@ -2,21 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef UI_BASE_KEYCODES_KEYBOARD_CODE_CONVERSION_H_
-#define UI_BASE_KEYCODES_KEYBOARD_CODE_CONVERSION_H_
+#ifndef CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
+#define CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
#pragma once
#include "ui/base/keycodes/keyboard_codes.h"
+#include "views/event.h"
#include <string>
-namespace ui {
-
// Convert a KeyIdentifer (see Section 6.3.3 here:
// http://www.w3.org/TR/DOM-Level-3-Events/#keyset-keyidentifiers)
-// to a ui::KeyboardCode.
-KeyboardCode KeyCodeFromKeyIdentifier(const std::string& key_identifier);
-
-} // namespace ui
+// to a views::KeyEvent.
+const views::KeyEvent& KeyEventFromKeyIdentifier(
+ const std::string& key_identifier);
-#endif // UI_BASE_KEYCODES_KEYBOARD_CODE_CONVERSION_H_
+#endif // CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
« no previous file with comments | « chrome/browser/extensions/extension_input_api.cc ('k') | chrome/browser/extensions/key_identifier_conversion_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698