Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: content/renderer/webcrypto/webcrypto_impl_openssl.cc

Issue 62633004: [webcrypto] Add RSA public key SPKI import/export for NSS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for eroman Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/webcrypto/webcrypto_impl_openssl.cc
diff --git a/content/renderer/webcrypto/webcrypto_impl_openssl.cc b/content/renderer/webcrypto/webcrypto_impl_openssl.cc
index 23f89c2e04b2d9cebe53dc5c3aa46eee866cec1d..fae943a1bc851623cdd3789af63d238646ace5f0 100644
--- a/content/renderer/webcrypto/webcrypto_impl_openssl.cc
+++ b/content/renderer/webcrypto/webcrypto_impl_openssl.cc
@@ -330,14 +330,9 @@ bool WebCryptoImpl::ImportKeyInternal(
return false;
}
- // TODO(padolph): Need to split handling for symmetric (raw or jwk format) and
- // asymmetric (jwk, spki, or pkcs8 format) keys.
+ // TODO(padolph): Need to split handling for symmetric
// Currently only supporting symmetric.
- // TODO(padolph): jwk handling. Define precedence between jwk contents and
- // this method's parameters, e.g. 'alg' in jwk vs algorithm.id(). Who wins if
- // they differ? (jwk, probably)
-
// Symmetric keys are always type secret
WebKit::WebCryptoKeyType type = WebKit::WebCryptoKeyTypeSecret;
@@ -369,6 +364,17 @@ bool WebCryptoImpl::ImportKeyInternal(
return true;
}
+bool WebCryptoImpl::ExportKeyInternal(
+ WebKit::WebCryptoKeyFormat format,
+ const WebKit::WebCryptoKey& key,
+ WebKit::WebArrayBuffer* buffer) {
+ // TODO(padolph): Implement raw export
+ // TODO(padolph): Implement spki export
+ // TODO(padolph): Implement pkcs8 export
+ // TODO(padolph): Implement jwk export
+ return false;
+}
+
bool WebCryptoImpl::SignInternal(
const WebKit::WebCryptoAlgorithm& algorithm,
const WebKit::WebCryptoKey& key,

Powered by Google App Engine
This is Rietveld 408576698