content/renderer/webcrypto/webcrypto_impl.cc - Issue 62633004: [webcrypto] Add RSA public key SPKI import/export for NSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/webcrypto/webcrypto_impl.cc

Issue 62633004: [webcrypto] Add RSA public key SPKI import/export for NSS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes for eroman Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/webcrypto/webcrypto_impl.h ('k') | content/renderer/webcrypto/webcrypto_impl_nss.cc » ('j') | content/renderer/webcrypto/webcrypto_impl_nss.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/webcrypto/webcrypto_impl.cc

diff --git a/content/renderer/webcrypto/webcrypto_impl.cc b/content/renderer/webcrypto/webcrypto_impl.cc

index 38dc7729f87e796ef1dc19c60d2ace7dcfd7fb10..173a6fddf64d65e02c9e9c368221978609f07398 100644

--- a/content/renderer/webcrypto/webcrypto_impl.cc

+++ b/content/renderer/webcrypto/webcrypto_impl.cc

@@ -156,6 +156,18 @@ void WebCryptoImpl::importKey(

result.completeWithKey(key);

}

+void WebCryptoImpl::exportKey(

+ WebKit::WebCryptoKeyFormat format,

+ const WebKit::WebCryptoKey& key,

+ WebKit::WebCryptoResult result) {

+ WebKit::WebArrayBuffer buffer;

+ if (!ExportKeyInternal(format, key, &buffer)) {

+ result.completeWithError();

+ return;

+ }

+ result.completeWithBuffer(buffer);

void WebCryptoImpl::sign(

const WebKit::WebCryptoAlgorithm& algorithm,

const WebKit::WebCryptoKey& key,