Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 62633004: [webcrypto] Add RSA public key SPKI import/export for NSS. (Closed)

Created:
7 years, 1 month ago by padolph
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[webcrypto] Add RSA public key SPKI import/export for NSS. BUG=245025 TEST=content_unittests --gtest_filter="WebCryptoImpl*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237255

Patch Set 1 #

Total comments: 19

Patch Set 2 : fixes for eroman #

Total comments: 3

Patch Set 3 : (minor) fixes for eroman #

Patch Set 4 : reabse #

Total comments: 2

Patch Set 5 : changes for rsleevi #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -80 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 2 3 4 3 chunks +224 lines, -70 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_openssl.cc View 1 2 3 2 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 2 3 6 chunks +113 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
padolph
New NSS functions used in the CL: SECKEY_DecodeDERSubjectPublicKeyInfo SECKEY_ExtractPublicKey SECKEY_GetPublicKeyType SECKEY_EncodeDERSubjectPublicKeyInfo I think this requires ...
7 years, 1 month ago (2013-11-06 23:07:21 UTC) #1
eroman
Thanks! Mostly looksgood > I think this requires a change to some DEPS files again, ...
7 years, 1 month ago (2013-11-06 23:48:40 UTC) #2
padolph
https://codereview.chromium.org/62633004/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/62633004/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode256 content/renderer/webcrypto/webcrypto_impl_nss.cc:256: // TODO(eroman): Currently expects algorithm to always be specified, ...
7 years, 1 month ago (2013-11-07 00:23:50 UTC) #3
padolph
(manual email) On Wed, Nov 6, 2013 at 3:48 PM, <eroman@chromium.org> wrote: > Thanks! Mostly ...
7 years, 1 month ago (2013-11-07 00:25:00 UTC) #4
eroman
Note that I will remove jochen@ as reviewer, unless there was anything specific you needed ...
7 years, 1 month ago (2013-11-07 00:43:29 UTC) #5
eroman
By the way, I modified the description of your changelist: (1) Changed BUG=267888 to BUG=245025 ...
7 years, 1 month ago (2013-11-07 00:45:19 UTC) #6
padolph
On 2013/11/07 00:45:19, eroman wrote: > By the way, I modified the description of your ...
7 years, 1 month ago (2013-11-07 01:10:36 UTC) #7
padolph
https://codereview.chromium.org/62633004/diff/70001/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/62633004/diff/70001/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode344 content/renderer/webcrypto/webcrypto_impl_nss.cc:344: if (!key_data || !key_data_size) On 2013/11/07 00:43:29, eroman wrote: ...
7 years, 1 month ago (2013-11-07 01:19:08 UTC) #8
eroman
Still LGTM. @rsleevi: Were you planning on looking at this?
7 years, 1 month ago (2013-11-20 23:22:03 UTC) #9
Ryan Sleevi
I've only briefly scanned, not reviewed in depth. I'm assuming Eric's done the full review, ...
7 years, 1 month ago (2013-11-21 01:19:11 UTC) #10
padolph
https://codereview.chromium.org/62633004/diff/210001/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/62633004/diff/210001/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode430 content/renderer/webcrypto/webcrypto_impl_nss.cc:430: static_cast<unsigned char*>(buffer->data())); On 2013/11/21 01:19:12, Ryan Sleevi wrote: > ...
7 years, 1 month ago (2013-11-21 02:13:35 UTC) #11
Ryan Sleevi
lgtm
7 years ago (2013-11-25 06:30:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/62633004/360001
7 years ago (2013-11-25 20:02:45 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=228790
7 years ago (2013-11-26 00:47:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/62633004/360001
7 years ago (2013-11-26 03:08:10 UTC) #15
commit-bot: I haz the power
7 years ago (2013-11-26 04:26:35 UTC) #16
Message was sent while issue was closed.
Change committed as 237255

Powered by Google App Engine
This is Rietveld 408576698