Object.is should use SameValue

Object.is should use SameValue

BUG=v8:3576
LOG=

[Diego Pino, 2014-10-04 09:46:01]

dpino@igalia.com changed reviewers:
+ wingo@igalia.com

[Diego Pino, 2014-10-04 09:46:38]

Please take a look, thanks! :)

[Diego Pino, 2014-10-04 09:48:10]

I wonder if the test file should be protected by a harmony flag, as it tests a
ES6 feature. Also, I think the test should be moved to test/mjsunit/harmony/.

[arv (Not doing code reviews), 2014-10-04 16:12:05]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2014-10-04 16:12:06]

LGTM

We are already shipping this. If you want to move the test you can move it to
test/mjsunit/es6/

https://codereview.chromium.org/626323002/diff/1/test/mjsunit/object-is.js
File test/mjsunit/object-is.js (right):

https://codereview.chromium.org/626323002/diff/1/test/mjsunit/object-is.js#ne...
test/mjsunit/object-is.js:35: var test_set = [ {}, [], Number.POSITIVE_INFINITY,
Number.NEGATIVE_INFINITY,
Use Infinity and -Infinity instead? These tests are run in a clean environment
so these are not redfined.

https://codereview.chromium.org/626323002/diff/1/test/mjsunit/object-is.js#ne...
test/mjsunit/object-is.js:37: Number.NaN ];
NaN

https://codereview.chromium.org/626323002/diff/1/test/mjsunit/object-is.js#ne...
test/mjsunit/object-is.js:38: print(test_set);
remove print?

[wingo (chromium), 2014-10-07 10:07:39]

wingo@chromium.org changed reviewers:
+ wingo@chromium.org

[wingo (chromium), 2014-10-07 10:07:39]

No need to put "ditto" in the description -- if the one-line summary is
sufficient that's fine.  I have edited the description.

[wingo, 2014-10-07 11:10:15]

wingo@igalia.com changed reviewers:
- wingo@chromium.org

[wingo, 2014-10-07 11:10:15]

lgtm as well, please add an owner

[Diego Pino, 2014-10-07 11:15:51]

dpino@igalia.com changed reviewers:
+ svenpanne@chromium.org

[Diego Pino, 2014-10-07 11:15:52]

Please, could you take a look? Thanks :)

[Diego Pino, 2014-10-12 19:19:45]

Sven Panne: "git cl owner" suggested me you as an owner. The issue is already
reviewed by non-owners. Could you please take a look? Thanks :)

[Sven Panne, 2014-10-14 10:27:30]

lgtm

[wingo (chromium), 2014-10-16 11:16:55]

On 2014/10/14 10:27:30, Sven Panne wrote:
> lgtm

will land

[wingo (chromium), 2014-10-16 11:26:40]

Committed patchset #2 manually as 24658 (presubmit successful).