pkg/analysis_server/lib/src/services/completion/local_computer.dart - Issue 626303002: filter undesired suggestions from prefix expression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 626303002: filter undesired suggestions from prefix expression (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_computer.dart ('k') | pkg/analysis_server/test/services/completion/imported_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart

index 7676381f0d6d265e4758a2f943cb695c3f597dc2..73319916d2ea00ac5341f6313b78e1203427193c 100644

--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart

@@ -159,6 +159,16 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {

}

@override

+ visitPrefixedIdentifier(PrefixedIdentifier node) {

+ // InvocationComputer adds suggestions for prefixed elements

+ // but this computer adds suggestions for the prefix itself

+ SimpleIdentifier prefix = node.prefix;

+ if (prefix == null || request.offset <= prefix.end) {

+ visitNode(node);

+ }

+ @override

visitForStatement(ForStatement node) {

var varList = node.variables;

if (varList != null) {