filter undesired suggestions from prefix expression

pkg/analysis_server/test/services/completion/local_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.dart.local;
 
 import 'package:analysis_server/src/services/completion/local_computer.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
@@ skipping 106 matching lines @@
     assertSuggestLocalVariable('foo', null);
   }
 
   test_ForStatement_body() {
     // Block  ForStatement
     addTestSource('main(args) {for (int i; i < 10; ++i) {^}}');
     expect(computeFast(), isTrue);
     assertSuggestLocalVariable('i', 'int');
   }
 
+  test_ForStatement_condition() {
+    // SimpleIdentifier  ForStatement
+    addTestSource('main() {for (int index = 0; i^)}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('index', 'int');
+  }
+
+  test_ForStatement_updaters() {
+    // SimpleIdentifier  ForStatement
+    addTestSource('main() {for (int index = 0; index < 10; i^)}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('index', 'int');
+  }
+
+  test_ForStatement_updaters_prefix_expression() {
+    // SimpleIdentifier  PrefixExpression  ForStatement
+    addTestSource('main() {for (int index = 0; index < 10; ++i^)}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('index', 'int');
+  }
+
   test_FunctionExpression_body_function() {
     // Block  BlockFunctionBody  FunctionExpression
     addTestSource('String foo(List args) {x.then((R b) {^});}');
     expect(computeFast(), isTrue);
     var f = assertSuggestFunction('foo', 'String', false);
     expect(f.element.isPrivate, isFalse);
     assertSuggestParameter('args', 'List');
     assertSuggestParameter('b', 'R');
   }
 
   test_InstanceCreationExpression() {
     // SimpleIdentifier  TypeName  ConstructorName  InstanceCreationExpression
     addTestSource('class A {a() {var f; {var x;} new ^}} class B { }');
     expect(computeFast(), isTrue);
     assertSuggestClass('A');
     assertSuggestClass('B');
     // TODO (danrubel) should only suggest types
     //assertNotSuggested('a');
     assertSuggestMethod('a', 'A', null);
     //assertNotSuggested('f');
     assertSuggestLocalVariable('f', null);
     assertNotSuggested('x');
   }
 
+  test_InterpolationExpression() {
+    // SimpleIdentifier  InterpolationExpression  StringInterpolation
+    addTestSource('main() {String name; print("hello \$^");}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('name', 'String');
+  }
+
+  test_InterpolationExpression_block() {
+    // SimpleIdentifier  InterpolationExpression  StringInterpolation
+    addTestSource('main() {String name; print("hello \${n^}");}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('name', 'String');
+  }
+
   test_MethodDeclaration_body_getters() {
     // Block  BlockFunctionBody  MethodDeclaration
     addTestSource('class A {@deprecated X get f => 0; Z a() {^} get _g => 1;}');
     expect(computeFast(), isTrue);
     var a = assertSuggestMethod('a', 'A', 'Z');
     expect(a.element.isDeprecated, isFalse);
     expect(a.element.isPrivate, isFalse);
     var f = assertSuggestGetter('f', 'X');
     expect(f.element.isDeprecated, isTrue);
     expect(f.element.isPrivate, isFalse);
@@ skipping 30 matching lines @@
 
   test_MethodDeclaration_parameters_positional() {
     // Block  BlockFunctionBody  MethodDeclaration
     addTestSource('class A {Z a(X x, [int y=1]) {^}}');
     expect(computeFast(), isTrue);
     assertSuggestMethod('a', 'A', 'Z');
     assertSuggestParameter('x', 'X');
     assertSuggestParameter('y', 'int');
   }
 
+  test_PrefixedIdentifier() {
+    // SimpleIdentifier  PrefixedIdentifier  ExpressionStatement
+    addTestSource('''
+      class A {var b; X _c;}
+      class X{}
+      main() {A a; a.^}''');
+    expect(computeFast(), isTrue);
+    // PrefixedIdentifier is handled by InvocationComputer
+    assertNotSuggested('b');
+    assertNotSuggested('_c');
+  }
+
+  test_PrefixedIdentifier_interpolation() {
+    // SimpleIdentifier  PrefixedIdentifier  InterpolationExpression
+    addTestSource('main() {String name; print("hello \${name.^}");}');
+    expect(computeFast(), isTrue);
+    // InvocationComputer creates suggestions for prefixed identifiers
+    assertNotSuggested('name');
+    assertNotSuggested('length');
+  }
+
+  test_PrefixedIdentifier_prefix() {
+    // SimpleIdentifier  PrefixedIdentifier  InterpolationExpression
+    addTestSource('main() {String name; print("hello \${nam^e.length}");}');
+    expect(computeFast(), isTrue);
+    assertSuggestLocalVariable('name', 'String');
+    assertNotSuggested('length');
+  }
+
   test_TopLevelVariableDeclaration_typed_name() {
     // SimpleIdentifier  VariableDeclaration  VariableDeclarationList
     // TopLevelVariableDeclaration
     addTestSource('class A {} B ^');
     expect(computeFast(), isTrue);
     assertNotSuggested('A');
   }
 
   test_TopLevelVariableDeclaration_untyped_name() {
     // SimpleIdentifier  VariableDeclaration  VariableDeclarationList
     // TopLevelVariableDeclaration
     addTestSource('class A {} var ^');
     expect(computeFast(), isTrue);
     assertNotSuggested('A');
   }
 
   test_VariableDeclarationStatement_name() {
     // SimpleIdentifier  VariableDeclaration  VariableDeclarationList
     // VariableDeclarationStatement
     addTestSource('class _A {a() {var f; var ^}}');
     expect(computeFast(), isTrue);
     assertNotSuggested('A');
     assertNotSuggested('a');
     assertNotSuggested('f');
   }
 
   test_VariableDeclaration_RHS() {
-
-        // VariableDeclaration  VariableDeclarationList  VariableDeclarationStatement
+    // VariableDeclaration  VariableDeclarationList
+    // VariableDeclarationStatement
     addTestSource('class A {a() {var f; {var x;} var e = ^ var g;}}');
     expect(computeFast(), isTrue);
     assertSuggestClass('A');
     assertSuggestLocalVariable('f', null);
     assertNotSuggested('g');
     assertNotSuggested('x');
   }
 }