Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 626223002: Add unboxed Mint for X64 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 03f8a723c50c2055c90b35932f6fcaf223b3604e..ee72153ec26bec7dd1b8dd70ba26d067f887db7b 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -5903,13 +5903,6 @@ void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(locs()->in(1).constant().IsSmi());
const int32_t shift =
reinterpret_cast<int32_t>(locs()->in(1).constant().raw()) >> 1;
- if ((shift < 0) || (shift > kMintShiftCountLimit)) {
- __ jmp(deopt);
- return;
- } else if (shift == 0) {
- // Nothing to do for zero shift amount.
- return;
- }
switch (op_kind()) {
case Token::kSHR: {
if (shift > 31) {
@@ -6138,12 +6131,7 @@ void ShiftUint32OpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
const intptr_t shift_value = Smi::Cast(constant).Value();
// Check constant shift value.
- if (shift_value == 0) {
- // Nothing to do.
- } else if (shift_value < 0) {
- // Invalid shift value.
- __ jmp(deopt);
- } else if (shift_value > kShifterLimit) {
+ if (shift_value > kShifterLimit) {
Vyacheslav Egorov (Google) 2014/10/07 12:03:50 Ditto.
Cutch 2014/10/21 17:42:11 Done.
// Result is 0.
__ xorl(left, left);
} else {

Powered by Google App Engine
This is Rietveld 408576698