Add unboxed Mint for X64

runtime/vm/intermediate_language_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/cpu.h"
@@ skipping 6263 matching lines @@
 
   Label* deopt = NULL;
   if (CanDeoptimize()) {
     deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptShiftMintOp);
   }
   if (locs()->in(1).IsConstant()) {
     // Code for a constant shift amount.
     ASSERT(locs()->in(1).constant().IsSmi());
     const int32_t shift =
         reinterpret_cast<int32_t>(locs()->in(1).constant().raw()) >> 1;
-    if ((shift < 0) || (shift > kMintShiftCountLimit)) {
-      __ b(deopt);
-      return;
-    } else if (shift == 0) {
-      // Nothing to do for zero shift amount.
-      __ mov(out_lo, Operand(left_lo));
-      __ mov(out_hi, Operand(left_hi));
-      return;
-    }
     switch (op_kind()) {
       case Token::kSHR: {
         if (shift < 32) {
           __ Lsl(out_lo, left_hi, 32 - shift);
           __ orr(out_lo, out_lo, Operand(left_lo, LSR, shift));
           __ Asr(out_hi, left_hi, shift);
         } else {
           if (shift == 32) {
             __ mov(out_lo, Operand(left_hi));
           } else {
@@ skipping 211 matching lines @@
   Label* deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptShiftMintOp);
 
   if (locs()->in(1).IsConstant()) {
     // Shifter is constant.
 
     const Object& constant = locs()->in(1).constant();
     ASSERT(constant.IsSmi());
     const intptr_t shift_value = Smi::Cast(constant).Value();
 
     // Check constant shift value.
-    if (shift_value == 0) {
-      // Nothing to do.
-      __ mov(out, Operand(left));
-    } else if (shift_value < 0) {
-      // Invalid shift value.
-      __ b(deopt);
-    } else if (shift_value > kShifterLimit) {
+    if (shift_value > kShifterLimit) {

[Vyacheslav Egorov (Google), 2014/10/07 12:03:50]

Can't this also be handled in Canonicalize just like other cases?

If it's not handled yet, please just move there so that all platforms will
benefit.

[Cutch, 2014/10/21 17:42:11]

Done.

       // Result is 0.
       __ eor(out, out, Operand(out));
     } else {
       // Do the shift: (shift_value > 0) && (shift_value <= kShifterLimit).
       switch (op_kind()) {
         case Token::kSHR:
           __ Lsr(out, left, shift_value);
           break;
         case Token::kSHL:
           __ Lsl(out, left, shift_value);
@@ skipping 478 matching lines @@
   compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
 #if defined(DEBUG)
   __ LoadImmediate(R4, kInvalidObjectPointer);
   __ LoadImmediate(R5, kInvalidObjectPointer);
 #endif
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM