Implement extended syntax for AVC/h264 unit tests

Implement extended syntax for AVC/h264 unit tests

Currently supported syntax is just a string of space-
separated NALU types. Each NALU is currently placed in a
separate subsample. This change introduces comma as an
additional separator. NALUs separated by commas will be
placed in the same subsample. NALU groups separated by
spaces will be placed in separate subsamples.
For example: "AUD,SEI SPS" means there will be two
subsamples. AUD and SEI in first subsample, SPS in second.
I'm planning to use this new syntax to implement a unit test for https://codereview.chromium.org/591713002/

BUG=

Committed: https://crrev.com/8da014420d48fd96b61dadd894ffda97b9ea895e
Cr-Commit-Position: refs/heads/master@{#298620}

[servolk, 2014-10-04 00:13:34]

servolk@chromium.org changed reviewers:
+ dalecurtis@chromium.org, damienv@chromium.org, wolenetz@chromium.org

[servolk, 2014-10-07 21:53:46]

PTAL

[wolenetz, 2014-10-07 23:37:40]

lgtm % nits

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
File media/formats/mp4/avc_unittest.cc (right):

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:122: void StringToAnnexB(const std::string&
str, std::vector<uint8>* buffer,
nit: Document the format of |str| in method comment now that it is less trivial.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:126: std::vector<std::string> tokens;
nit: s/tokens/subsample_specs/

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:177: DCHECK(false);
nit: NOTREACHED();

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:190: size_t current_subsample = 0;
nit: s/ple/ple_index/

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:192: size_t subsample =
FindSubsampleIndex(buffer, &subsamples, nalu.data);
nit: ditto

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:196: first = false;
nit: maybe add a DCHECK_EQ(subsample_index, current_subsample) in this else
clause?

[servolk, 2014-10-07 23:57:19]

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
File media/formats/mp4/avc_unittest.cc (right):

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:122: void StringToAnnexB(const std::string&
str, std::vector<uint8>* buffer,
On 2014/10/07 23:37:40, wolenetz wrote:
> nit: Document the format of |str| in method comment now that it is less
trivial.

Done.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:126: std::vector<std::string> tokens;
On 2014/10/07 23:37:40, wolenetz wrote:
> nit: s/tokens/subsample_specs/

Done.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:177: DCHECK(false);
On 2014/10/07 23:37:39, wolenetz wrote:
> nit: NOTREACHED();

Done.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:190: size_t current_subsample = 0;
On 2014/10/07 23:37:39, wolenetz wrote:
> nit: s/ple/ple_index/

Done.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:192: size_t subsample =
FindSubsampleIndex(buffer, &subsamples, nalu.data);
On 2014/10/07 23:37:39, wolenetz wrote:
> nit: ditto

Done.

https://codereview.chromium.org/626193003/diff/20001/media/formats/mp4/avc_un...
media/formats/mp4/avc_unittest.cc:196: first = false;
On 2014/10/07 23:37:39, wolenetz wrote:
> nit: maybe add a DCHECK_EQ(subsample_index, current_subsample) in this else
> clause?

Done.

[servolk, 2014-10-07 23:58:03]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2014-10-07 23:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/626193003/40001

[commit-bot: I haz the power, 2014-10-08 00:40:01]

Committed patchset #3 (id:40001) as ac951b4c45d27ff533b9914f19d659b1eb53917f

[commit-bot: I haz the power, 2014-10-08 00:41:29]

Patchset 3 (id:??) landed as
https://crrev.com/8da014420d48fd96b61dadd894ffda97b9ea895e
Cr-Commit-Position: refs/heads/master@{#298620}