Fix a long standing bug with the browser window losing focus when the user scrolled on the page usi…

Fix a long standing bug with the browser window losing focus when the user scrolled on the page using certain trackpad drivers.

The bug occurs because the browser window receives a WM_MOUSEACTIVATE message when the trackpad is
operated on the web page. There is code in the HWNDMessageHandler::OnMouseActivate function which
checks if the window under the cursor is a child window and if yes it causes the focus manager
to lose activation. This code was added to support activation in windowed NPAPI plugins.

It causes this issue because the child window in question here is the legacy RenderWidgetHostHWND
class.

Fix for now is to ignore transparent child windows. Added a TODO in HWNDMessageHandler to remove the
child window related code once we deprecate NPAPI plugins.

BUG=351995
Committed: https://crrev.com/9d7d7494a5d2ceedde75f88ecd0bb6866044eea0
Cr-Commit-Position: refs/heads/master@{#298151}

[ananta, 2014-10-03 22:16:07]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-10-03 22:53:09]

LGTM

https://codereview.chromium.org/626183002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/626183002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:1554: // transparent child windows in this
bucket.
Document why we don't include transparent ones.

[ananta, 2014-10-04 00:10:09]

https://codereview.chromium.org/626183002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/626183002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:1554: // transparent child windows in this
bucket.
On 2014/10/03 22:53:09, sky wrote:
> Document why we don't include transparent ones.

Done.

[ananta, 2014-10-04 00:15:29]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-10-04 00:19:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/626183002/20001

[commit-bot: I haz the power, 2014-10-04 01:18:45]

Committed patchset #2 (id:20001) as eb8661a67f65ec2fa55428955f8d3f8086b2d6c0

[commit-bot: I haz the power, 2014-10-04 01:20:11]

Patchset 2 (id:??) landed as
https://crrev.com/9d7d7494a5d2ceedde75f88ecd0bb6866044eea0
Cr-Commit-Position: refs/heads/master@{#298151}