Cleanup webview app_shell_browsertests and add webview media permission tests in app_shell_browsert…

extensions/test/data/web_view/media_access/allow/embedder.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var embedder = {};
 embedder.tests = {};
-embedder.baseGuestURL = '';

[lazyboy, 2014/10/06 16:21:21]

I'd keep these two as they make things readable, i.e. one can assume there would
be "baseGuestURL" and "guestURL" defined under the "embedder" object, you can
add a comment saying "These will be filled in chrome.test.getConfig() below".

[lfg, 2014/10/06 16:53:18]

Done.

-embedder.guestURL = '';
 
 // Sends a message to WebViewTest denoting it is done and test
 // has failed.
 embedder.failTest = function(msg) {
-  window.console.log('test failure, reason: ' + msg);
+  window.console.warn('test failure, reason: ' + msg);
   chrome.test.sendMessage('TEST_FAILED');
 };
 
 // Sends a message to WebViewTest denoting it is done and test
 // has succeeded.
 embedder.maybePassTest = function() {
-  window.console.log('test passed');
   chrome.test.sendMessage('TEST_PASSED');
 };
 
 /** @private */
 embedder.setUpGuest_ = function() {
   document.querySelector('#webview-tag-container').innerHTML =
       '<webview style="width: 100px; height: 100px;"' +
       ' src="' + embedder.guestURL + '"' +
       '></webview>';
   var webview = document.querySelector('webview');
@@ skipping 99 matching lines @@
   };
   var onPermissionRequest2 = function(e) {
     checkAndCall(e);
   };
   webview.addEventListener('permissionrequest', onPermissionRequest1);
   webview.addEventListener('permissionrequest', onPermissionRequest2);
 
   embedder.setUpLoadStop_(webview, 'test1');
 };
 
+embedder.tests.testAllowAsync = function() {
+  var webview = embedder.setUpGuest_();
+  if (!webview) {
+    return;
+  }
+
+  var onPermissionRequest = function(e) {
+    if (!embedder.assertCorrectMediaEvent_(e)) {
+      return;
+    }
+
+    e.preventDefault();
+    // Decide asynchronously.
+    window.setTimeout(function() {
+      e.request.allow();
+      embedder.maybePassTest();
+    }, 0);
+  };
+  webview.addEventListener('permissionrequest', onPermissionRequest);
+
+  embedder.setUpLoadStop_(webview, 'test1');
+};
+
 embedder.tests.testAllowTwice = function() {
   var webview = embedder.setUpGuest_();
   if (!webview) {
     return;
   }
 
   var calledAllow = false;
   var callbackCount = 0;
   var exceptionCount = 0;
   var checkAndCall = function(e) {
@@ skipping 23 matching lines @@
   };
   var onPermissionRequest2 = function(e) {
     checkAndCall(e);
   };
   webview.addEventListener('permissionrequest', onPermissionRequest1);
   webview.addEventListener('permissionrequest', onPermissionRequest2);
 
   embedder.setUpLoadStop_(webview, 'test1');
 };
 
-embedder.tests.testAllowAsync = function() {
-  var webview = embedder.setUpGuest_();
-  if (!webview) {
-    return;
-  }
-
-  var onPermissionRequest = function(e) {
-    if (!embedder.assertCorrectMediaEvent_(e)) {
-      return;
-    }
-
-    e.preventDefault();
-    // Decide asynchronously.
-    window.setTimeout(function() {
-      e.request.allow();
-      embedder.maybePassTest();
-    }, 0);
-  };
-  webview.addEventListener('permissionrequest', onPermissionRequest);
-
-  embedder.setUpLoadStop_(webview, 'test1');
-};
-
 embedder.tests.list = {
   'testAllow': embedder.tests.testAllow,
   'testAllowAndThenDeny': embedder.tests.testAllowAndThenDeny,
-  'testAllowTwice': embedder.tests.testAllowTwice,
-  'testAllowAsync': embedder.tests.testAllowAsync
+  'testAllowAsync': embedder.tests.testAllowAsync,
+  'testAllowTwice': embedder.tests.testAllowTwice
 };
 
 // Entry point for test, called by WebViewTest.
-function startAllowTest(testName) {
+function runTest(testName) {
   chrome.test.getConfig(function(config) {
     embedder.baseGuestURL = 'http://localhost:' + config.testServer.port;
-    embedder.guestURL = embedder.baseGuestURL +
-        '/extensions/platform_apps/web_view/media_access' +
-        '/media_access_guest.html';
+    embedder.guestURL = embedder.baseGuestURL + '/media_access_guest.html';
     chrome.test.log('Guest url is: ' + embedder.guestURL);
 
     var testFunction = embedder.tests.list[testName];
     if (!testFunction) {
       embedder.failTest('No such test: ' + testName);
       return;
     }
     testFunction();
   });
 }
 
 onload = function() {
-  chrome.test.sendMessage('Launched');
+  chrome.test.sendMessage('LAUNCHED');
 };