AccExplorer shouldn't crash when pointed at chromium....

AccExplorer shouldn't crash when pointed at chromium.

webaccessibility.h/cc
- Change type of OutParams::return_code from bool to int to allow more return codres, specifically RETURNCODE_FAIL.
- Add enum ReturnCode to list possible return codes for OutParams::return_code.
- Fix up WebAccessibility::GetAccObjInfo so that it returns a failure when an attempt is made to access an invalid object.

browseraccessibility.h/cc
- Renamed EmptyVariant to ChildSelfVariant since RequestAccessibilityInfo always expects to receive a valid VT_I4 variant for the var_id parameter.
- Update RequestAccessibilityInfo so that it returns false if the return_code is RETURNCODE_FAIL.

renderview.cc
- In RenderView::UpdateURL, completely reset the accessibility cache to it can be successfully recreated and initialized again in RenderView::OnGetAccessibilityInfo.
- Set the return_code in RenderView::OnGetAccessibilityInfo.

BUG=36162
TEST=Point AccExplorer32 at Chrome an verify that it can successfully display the full accessibility tree.

[jcampan, 2010-02-19 22:11:33]

http://codereview.chromium.org/626014/diff/6001/6004
File chrome/browser/browser_accessibility.cc (right):

http://codereview.chromium.org/626014/diff/6001/6004#newcode342
chrome/browser/browser_accessibility.cc:342: ||
response().output_string.empty()) {
Style: || should be on the previous line.

http://codereview.chromium.org/626014/diff/6001/6004#newcode505
chrome/browser/browser_accessibility.cc:505: ||
response().output_string.empty()) {
Style: || should be on the previous line.

http://codereview.chromium.org/626014/diff/6001/6004#newcode559
chrome/browser/browser_accessibility.cc:559: && response().return_code !=
WebAccessibility::RETURNCODE_FAIL;
Style: && should be on previous line.

http://codereview.chromium.org/626014/diff/6001/6005
File chrome/browser/browser_accessibility.h (right):

http://codereview.chromium.org/626014/diff/6001/6005#newcode129
chrome/browser/browser_accessibility.h:129: // Creates an interger VARIANT that
will reference the current accessibility
Typo: interger

http://codereview.chromium.org/626014/diff/6001/6006
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/626014/diff/6001/6006#newcode3559
chrome/renderer/render_view.cc:3559:
webkit_glue::WebAccessibility::GetAccObjInfo(accessibility_.get(),
Style: should be 4 space indented.

[ctguil, 2010-02-19 23:29:58]

http://codereview.chromium.org/626014/diff/6001/6004
File chrome/browser/browser_accessibility.cc (right):

http://codereview.chromium.org/626014/diff/6001/6004#newcode342
chrome/browser/browser_accessibility.cc:342: ||
response().output_string.empty()) {
On 2010/02/19 22:11:33, jcampan wrote:
> Style: || should be on the previous line.

Done.

http://codereview.chromium.org/626014/diff/6001/6004#newcode505
chrome/browser/browser_accessibility.cc:505: ||
response().output_string.empty()) {
On 2010/02/19 22:11:33, jcampan wrote:
> Style: || should be on the previous line.

Done.

http://codereview.chromium.org/626014/diff/6001/6004#newcode559
chrome/browser/browser_accessibility.cc:559: && response().return_code !=
WebAccessibility::RETURNCODE_FAIL;
On 2010/02/19 22:11:33, jcampan wrote:
> Style: && should be on previous line.

Done.

http://codereview.chromium.org/626014/diff/6001/6005
File chrome/browser/browser_accessibility.h (right):

http://codereview.chromium.org/626014/diff/6001/6005#newcode129
chrome/browser/browser_accessibility.h:129: // Creates an interger VARIANT that
will reference the current accessibility
On 2010/02/19 22:11:33, jcampan wrote:
> Typo: interger

Done.

http://codereview.chromium.org/626014/diff/6001/6006
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/626014/diff/6001/6006#newcode3559
chrome/renderer/render_view.cc:3559:
webkit_glue::WebAccessibility::GetAccObjInfo(accessibility_.get(),
On 2010/02/19 22:11:33, jcampan wrote:
> Style: should be 4 space indented.

Done.

[jcampan, 2010-02-20 00:47:00]

LGTM

http://codereview.chromium.org/626014/diff/10013/10018
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/626014/diff/10013/10018#newcode3560
chrome/renderer/render_view.cc:3560: in_params,
Nit: should be aligned to the params above.

[ctguil, 2010-02-22 19:12:03]

Can you submit this change for me? I'm in a read only client.

http://codereview.chromium.org/626014/diff/10013/10018
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/626014/diff/10013/10018#newcode3560
chrome/renderer/render_view.cc:3560: in_params,
On 2010/02/20 00:47:01, jcampan wrote:
> Nit: should be aligned to the params above.

Done.