content/public/browser/stream_info.cc - Issue 625993002: Split up streams logic to prepare for PlzNavigate RDH changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/stream_info.cc

Issue 625993002: Split up streams logic to prepare for PlzNavigate RDH changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: zork comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/public/browser/stream_info.h"

	6

	7 #include "content/public/browser/stream_handle.h"

	8 #include "net/http/http_response_headers.h"

	9

	10 namespace content {

	11

	12 StreamInfo::StreamInfo() {}
	jam 2014/10/15 16:11:00 nit: can you avoid this cc file and inline the con nit: can you avoid this cc file and inline the constructor (shouldn't need a d'tor I think) or will you get clang errors? we only add .cc files for structs if clang complains davidben 2014/10/15 16:12:29 The destructor isn't quite trivial because of the Show quoted text On 2014/10/15 16:11:00, jam wrote: > nit: can you avoid this cc file and inline the constructor (shouldn't need a > d'tor I think) or will you get clang errors? we only add .cc files for structs > if clang complains The destructor isn't quite trivial because of the scoped_ptr and the scoped_refptr. (Is that when clang complains?) davidben 2014/10/15 19:28:54 (Just checked with clang, and it does complain.) Show quoted text On 2014/10/15 16:12:29, David Benjamin wrote: > On 2014/10/15 16:11:00, jam wrote: > > nit: can you avoid this cc file and inline the constructor (shouldn't need a > > d'tor I think) or will you get clang errors? we only add .cc files for structs > > if clang complains > > The destructor isn't quite trivial because of the scoped_ptr and the > scoped_refptr. (Is that when clang complains?) (Just checked with clang, and it does complain.)
	13

	14 StreamInfo::~StreamInfo() {}

	15

	16 } // namespace content

OLD	NEW

« content/public/browser/stream_info.h ('K') | « content/public/browser/stream_info.h ('k') | no next file » | no next file with comments »