content/common/geolocation_messages.h - Issue 625963003: Do not send IPC message to cancel Geolocation permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/geolocation_messages.h

Issue 625963003: Do not send IPC message to cancel Geolocation permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geolocation/geolocation_dispatcher_host.h ('K') | « content/browser/geolocation/geolocation_dispatcher_host.cc ('k') | content/renderer/geolocation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/geolocation_messages.h

diff --git a/content/common/geolocation_messages.h b/content/common/geolocation_messages.h

index 55b4bd7736825cec9404e2d0402597a0d273d118..c016bf02e7aa2efd19f2f330fadac59666d7deed 100644

--- a/content/common/geolocation_messages.h

+++ b/content/common/geolocation_messages.h

@@ -46,21 +46,15 @@ IPC_MESSAGE_ROUTED1(GeolocationMsg_PositionUpdated,

// geolocation position. This will be replied by GeolocationMsg_PermissionSet.

IPC_MESSAGE_ROUTED3(GeolocationHostMsg_RequestPermission,

Charlie Reis 2014/10/07 21:35:35 nit: Same TODO. We should be using url::Origin or

mlamouri (slow - plz ping) 2014/10/08 09:24:33 Done.

int /* bridge_id */,

- GURL /* GURL of the frame requesting geolocation */,

+ GURL /* origin in the frame requesting geolocation */,

bool /* user_gesture */)

-// The |bridge_id| representing |GURL| is cancelling its previous permission

-// request to access geolocation position.

-IPC_MESSAGE_ROUTED2(GeolocationHostMsg_CancelPermissionRequest,

- int /* bridge_id */,

- GURL /* GURL of the frame */)

// The render view requests the Geolocation service to start updating.

// This is an asynchronous call, and the browser process may eventually reply

// with the updated geoposition, or an error (access denied, location

// unavailable, etc.)

IPC_MESSAGE_ROUTED2(GeolocationHostMsg_StartUpdating,

- GURL /* GURL of the frame requesting geolocation */,

+ GURL /* origin in the frame requesting geolocation */,

bool /* enable_high_accuracy */)

// The render view requests Geolocation service to stop updating.