LayoutTests/http/tests/serviceworker/resources/test-helpers.js - Issue 625943002: Catch uncaught promise rejections from V8 and log to console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

Issue 625943002: Catch uncaught promise rejections from V8 and log to console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: added promise.catch in test-helpers.js Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

diff --git a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

index 29f9f35da252834ac25175642ac5fb8a278d7006..bce1613150332dc92f7e40991d31329740e109e4 100644

--- a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

+++ b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

@@ -255,7 +255,7 @@ function test_login(test, origin, username, password) {

.then(test.step_func(function(frame) {

var channel = new MessageChannel();

channel.port1.onmessage = test.step_func(function() {

- unload_iframe(frame);

+ unload_iframe(frame).catch(function() {});

resolve();

});

frame.contentWindow.postMessage(