Source/core/workers/WorkerMessagingProxy.cpp - Issue 625943002: Catch uncaught promise rejections from V8 and log to console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerMessagingProxy.cpp

Issue 625943002: Catch uncaught promise rejections from V8 and log to console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/V8Initializer.cpp ('K') | « Source/core/workers/WorkerGlobalScope.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerMessagingProxy.cpp

diff --git a/Source/core/workers/WorkerMessagingProxy.cpp b/Source/core/workers/WorkerMessagingProxy.cpp

index 3fc69d9d5270a50a7cca958e0dfba16a2b9b9880..5faedbf548ea4b7ce5900ccb4b45236b529d5a39 100644

--- a/Source/core/workers/WorkerMessagingProxy.cpp

+++ b/Source/core/workers/WorkerMessagingProxy.cpp

@@ -176,7 +176,7 @@ void WorkerMessagingProxy::reportException(const String& errorMessage, int lineN

RefPtrWillBeRawPtr<ErrorEvent> event = ErrorEvent::create(errorMessage, sourceURL, lineNumber, columnNumber, 0);

bool errorHandled = !m_workerObject->dispatchEvent(event);

if (!errorHandled)

- m_executionContext->reportException(event, 0, nullptr, NotSharableCrossOrigin);

+ m_executionContext->reportException(event, 0, nullptr, nullptr, NotSharableCrossOrigin);

}

void WorkerMessagingProxy::reportConsoleMessage(MessageSource source, MessageLevel level, const String& message, int lineNumber, const String& sourceURL)