Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 625943002: Catch uncaught promise rejections from V8 and log to console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp
index 56f61e45cdda868b18fb0f14c47c1a497281707e..5568f206d46dbf58c436c70cf6a51e7cbd3f2fb0 100644
--- a/Source/bindings/core/v8/WorkerScriptController.cpp
+++ b/Source/bindings/core/v8/WorkerScriptController.cpp
@@ -46,6 +46,7 @@
#include "bindings/modules/v8/V8ServiceWorkerGlobalScope.h"
#include "core/events/ErrorEvent.h"
#include "core/frame/DOMTimer.h"
+#include "core/inspector/ScriptArguments.h"
#include "core/inspector/ScriptCallStack.h"
#include "core/workers/SharedWorkerGlobalScope.h"
#include "core/workers/WorkerGlobalScope.h"
@@ -264,7 +265,7 @@ void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, RefPtr
event = state.m_errorEventFromImportedScript.release();
else
event = ErrorEvent::create(state.errorMessage, state.sourceURL, state.lineNumber, state.columnNumber, m_world.get());
- m_workerGlobalScope.reportException(event, 0, nullptr, NotSharableCrossOrigin);
+ m_workerGlobalScope.reportException(event, 0, nullptr, nullptr, NotSharableCrossOrigin);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698