Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: Source/bindings/core/v8/ScriptValue.h

Issue 625943002: Catch uncaught promise rejections from V8 and log to console. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptValue.cpp » ('j') | Source/bindings/core/v8/V8Initializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptValue.h
diff --git a/Source/bindings/core/v8/ScriptValue.h b/Source/bindings/core/v8/ScriptValue.h
index d326c402d31161444ee3fac68ea8d13fdf001ede..cf8b441edd52abd20bad1964c1628368c62c6409 100644
--- a/Source/bindings/core/v8/ScriptValue.h
+++ b/Source/bindings/core/v8/ScriptValue.h
@@ -135,12 +135,18 @@ public:
m_value = nullptr;
}
+ int identityHash() const;
+
v8::Handle<v8::Value> v8Value() const;
v8::Handle<v8::Value> v8ValueUnsafe() const;
bool toString(String&) const;
PassRefPtr<JSONValue> toJSONValue(ScriptState*) const;
+ // Hash table deleted values, which are only constructed and never copied or destroyed.
+ ScriptValue(WTF::HashTableDeletedValueType) : m_scriptState(WTF::HashTableDeletedValue) { }
pfeldman 2014/10/06 13:11:59 Lets store them in a vector instead.
+ bool isHashTableDeletedValue() const { return m_scriptState.isHashTableDeletedValue(); }
+
private:
RefPtr<ScriptState> m_scriptState;
RefPtr<SharedPersistent<v8::Value> > m_value;
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptValue.cpp » ('j') | Source/bindings/core/v8/V8Initializer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698