Catch uncaught promise rejections from V8 and log to console.

Source/bindings/core/v8/V8Initializer.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/core/v8/V8Initializer.h"
 
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ScriptCallStackFactory.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/ScriptProfiler.h"
+#include "bindings/core/v8/ScriptValue.h"
+#include "bindings/core/v8/ScriptValueTraits.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8DOMException.h"
 #include "bindings/core/v8/V8ErrorEvent.h"
 #include "bindings/core/v8/V8ErrorHandler.h"
 #include "bindings/core/v8/V8GCController.h"
 #include "bindings/core/v8/V8History.h"
 #include "bindings/core/v8/V8Location.h"
 #include "bindings/core/v8/V8PerContextData.h"
 #include "bindings/core/v8/V8Window.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
+#include "core/dom/Microtask.h"
 #include "core/frame/ConsoleTypes.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
+#include "core/inspector/ScriptArguments.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/TraceEvent.h"
 #include "public/platform/Platform.h"
 #include "wtf/RefPtr.h"
 #include "wtf/text/WTFString.h"
 #include <v8-debug.h>
 
 namespace blink {
 
@@ skipping 84 matching lines @@
     }
 
     if (scriptState->world().isPrivateScriptIsolatedWorld()) {
         // We allow a private script to dispatch error events even in a EventDispatchForbiddenScope scope.
         // Without having this ability, it's hard to debug the private script because syntax errors
         // in the private script are not reported to console (the private script just crashes silently).
         // Allowing error events in private scripts is safe because error events don't propagate to
         // other isolated worlds (which means that the error events won't fire any event listeners
         // in user's scripts).
         EventDispatchForbiddenScope::AllowUserAgentEvents allowUserAgentEvents;
-        enteredWindow->document()->reportException(event.release(), scriptId, callStack, corsStatus);
+        enteredWindow->document()->reportException(event.release(), scriptId, callStack, nullptr, corsStatus);
     } else {
-        enteredWindow->document()->reportException(event.release(), scriptId, callStack, corsStatus);
+        enteredWindow->document()->reportException(event.release(), scriptId, callStack, nullptr, corsStatus);
     }
 }
 
+namespace {
+
+class PromiseRejectMessage {
+public:
+    PromiseRejectMessage(const ScriptValue& promise)
+        : m_promise(promise)
+    {
+    }
+
+    ScriptValue m_promise;
+};
+
+} // namespace
+
+typedef WillBeHeapHashMap<ScriptValue, OwnPtr<PromiseRejectMessage>, ScriptValueHash, ScriptValueHashTraits> PromiseRejectMessageMap;
+static bool firePromiseRejectMessagesCallbackScheduled = false;
+
+static PromiseRejectMessageMap& promiseRejectMessageQueue()
+{
+    DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<PromiseRejectMessageMap>, map, (adoptPtrWillBeNoop(new PromiseRejectMessageMap())));
+    return *map;
+}
+
+static void firePromiseRejectMessages()

[pfeldman, 2014/10/06 13:11:59]

Lets kick it from WebKit upon end of task instead.

+{
+    ASSERT(isMainThread());
+
+    firePromiseRejectMessagesCallbackScheduled = false;
+    v8::Isolate::GetCurrent()->RemoveCallCompletedCallback(&firePromiseRejectMessages);
+
+    // FIXME: Send more data from V8.
+    int scriptId = 0;
+    AccessControlStatus corsStatus = SharableCrossOrigin;
+    RefPtrWillBeRawPtr<ScriptCallStack> callStack = nullptr;
+
+    PromiseRejectMessageMap& map = promiseRejectMessageQueue();
+    while (!map.isEmpty()) {
+        PromiseRejectMessageMap::iterator it = map.begin();
+        OwnPtr<PromiseRejectMessage> message = it->value.release();
+        map.remove(it);
+
+        ScriptState* scriptState = message->m_promise.scriptState();
+        if (scriptState->contextIsValid())
+            continue;
+        ScriptState::Scope scope(scriptState);
+
+        v8::Isolate* isolate = scriptState->isolate();
+        RefPtrWillBeRawPtr<ErrorEvent> event = ErrorEvent::createSanitizedError(&scriptState->world());
+        event->setUnsanitizedMessage("Unhandled promise rejection");
+
+        Vector<ScriptValue> args;
+        args.append(ScriptValue(scriptState, v8String(isolate, event->messageForConsole())));
+        args.append(message->m_promise);
+        RefPtrWillBeRawPtr<ScriptArguments> arguments = ScriptArguments::create(scriptState, args);
+
+        scriptState->executionContext()->reportException(event.release(), scriptId, callStack, arguments.release(), corsStatus, true);

[pfeldman, 2014/10/06 13:11:59]

Accessing frame console for main thread and capturing arguments there seems
simpler.

+    }
+}
+
+static void promiseRejectHandlerInMainThread(v8::Handle<v8::Promise> promise, v8::Handle<v8::Value> value, v8::PromiseRejectEvent event)
+{
+    ASSERT(isMainThread());
+
+    // It's possible that promiseRejectHandlerInMainThread() is invoked while we're initializing a window.
+    // In that half-baked situation, we don't have a valid context nor a valid world,
+    // so just return immediately.
+    if (DOMWrapperWorld::windowIsBeingInitialized())
+        return;
+
+    v8::Isolate* isolate = v8::Isolate::GetCurrent();
+    ScriptState* scriptState = ScriptState::current(isolate);
+    ScriptValue promiseValue(scriptState, promise);
+    PromiseRejectMessageMap& map = promiseRejectMessageQueue();
+
+    if (event == v8::kPromiseRejectWithNoHandler) {
+        ASSERT(!map.contains(promiseValue));
+        map.set(promiseValue, adoptPtr(new PromiseRejectMessage(promiseValue)));
+    } else if (event == v8::kPromiseHandlerAddedAfterReject) {
+        PromiseRejectMessageMap::iterator it = map.find(promiseValue);
+        if (it != map.end()) {
+            map.remove(it);
+        } else {
+            // FIXME: Report revoke message to console.
+        }
+    } else {
+        ASSERT_NOT_REACHED();
+    }
+
+    if (!firePromiseRejectMessagesCallbackScheduled && !map.isEmpty()) {
+        firePromiseRejectMessagesCallbackScheduled = true;
+        isolate->AddCallCompletedCallback(&firePromiseRejectMessages);
+    }
+}
+
 static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8::AccessType type, v8::Local<v8::Value> data)
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     LocalFrame* target = findFrame(host, data, isolate);
     if (!target)
         return;
     LocalDOMWindow* targetWindow = target->domWindow();
 
     // FIXME: We should modify V8 to pass in more contextual information (context, property, and object).
     ExceptionState exceptionState(ExceptionState::UnknownContext, 0, 0, isolate->GetCurrentContext()->Global(), isolate);
@@ skipping 43 matching lines @@
     v8::Isolate* isolate = V8PerIsolateData::initialize();
 
     initializeV8Common(isolate);
 
     v8::V8::SetFatalErrorHandler(reportFatalErrorInMainThread);
     v8::V8::AddMessageListener(messageHandlerInMainThread);
     v8::V8::SetFailedAccessCheckCallbackFunction(failedAccessCheckCallbackInMainThread);
     v8::V8::SetAllowCodeGenerationFromStringsCallback(codeGenerationCheckCallbackInMainThread);
 
     isolate->SetEventLogger(timerTraceProfilerInMainThread);
+    isolate->SetPromiseRejectCallback(promiseRejectHandlerInMainThread);
 
     ScriptProfiler::initialize();
 }
 
 static void reportFatalErrorInWorker(const char* location, const char* message)
 {
     // FIXME: We temporarily deal with V8 internal error situations such as out-of-memory by crashing the worker.
     CRASH();
 }
 
@@ skipping 14 matching lines @@
         TOSTRING_VOID(V8StringResource<>, sourceURL, message->GetScriptOrigin().ResourceName());
         int scriptId = message->GetScriptOrigin().ScriptID()->Value();
 
         RefPtrWillBeRawPtr<ErrorEvent> event = ErrorEvent::create(errorMessage, sourceURL, message->GetLineNumber(), message->GetStartColumn() + 1, &DOMWrapperWorld::current(isolate));
         AccessControlStatus corsStatus = message->IsSharedCrossOrigin() ? SharableCrossOrigin : NotSharableCrossOrigin;
 
         // If execution termination has been triggered as part of constructing
         // the error event from the v8::Message, quietly leave.
         if (!v8::V8::IsExecutionTerminating(isolate)) {
             V8ErrorHandler::storeExceptionOnErrorEventWrapper(event.get(), data, scriptState->context()->Global(), isolate);
-            context->reportException(event.release(), scriptId, nullptr, corsStatus);
+            context->reportException(event.release(), scriptId, nullptr, nullptr, corsStatus);
         }
     }
 
     isReportingException = false;
 }
 
 static const int kWorkerMaxStackSize = 500 * 1024;
 
 void V8Initializer::initializeWorker(v8::Isolate* isolate)
 {
     initializeV8Common(isolate);
 
     v8::V8::AddMessageListener(messageHandlerInWorker);
     v8::V8::SetFatalErrorHandler(reportFatalErrorInWorker);
 
     uint32_t here;
     isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here - kWorkerMaxStackSize / sizeof(uint32_t*)));
 }
 
 } // namespace blink