src/trusted/validator_x86/testdata/64/mv_ebp_alone.test - Issue 625923004: Delete old x86 validator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/64/mv_ebp_alone.test

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator_x86/testdata/64/mv_ebp_add_rbp_r15.test ('k') | src/trusted/validator_x86/testdata/64/nacl_illegal.test » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/64/mv_ebp_alone.test

diff --git a/src/trusted/validator_x86/testdata/64/mv_ebp_alone.test b/src/trusted/validator_x86/testdata/64/mv_ebp_alone.test

deleted file mode 100644

index fab6f9af58362a645e4bee85b04bed5188dd6206..0000000000000000000000000000000000000000

--- a/src/trusted/validator_x86/testdata/64/mv_ebp_alone.test

+++ /dev/null

@@ -1,40 +0,0 @@

-@hex:

- # Test that we don't accept "mov %ebp, %r11d" if not followed by an "add %rbp %r15"

- 44 89 dd

-@val:

- VALIDATOR: 0000000000000000: 44 89 dd mov %ebp, %r11d

- VALIDATOR: ERROR: Illegal assignment to EBP

- VALIDATOR: Checking jump targets: 0 to 3

- VALIDATOR: Checking that basic blocks are aligned

- *** <input> IS UNSAFE ***

-@rval:

- VALIDATOR: 0000000000000000: 44 89 dd mov %ebp, %r11d

- VALIDATOR: ERROR: Illegal assignment to EBP

- VALIDATOR: Checking jump targets: 0 to 3

- VALIDATOR: Checking that basic blocks are aligned

- *** <input> IS UNSAFE ***

-@rvald:

- VALIDATOR: 0000000000000000: 44 89 dd mov %ebp, %r11d

- VALIDATOR: ERROR: Illegal assignment to EBP

- VALIDATOR: Checking block alignment and jump targets: 0 to 3

- *** <input> IS UNSAFE ***

-@vd-rval:

- VALIDATOR: 0000000000000000: 44 89 dd mov %ebp, %r11d

- VALIDATOR: ERROR: Illegal assignment to EBP

- VALIDATOR: Checking jump targets: 0 to 3

- VALIDATOR: Checking that basic blocks are aligned

- *** <input> IS UNSAFE ***

-@dis:

- 0000000000000000: 44 89 dd mov %ebp, %r11d

-@vdis:

- 0000000000000000: 44 89 dd mov %ebp, %r11d

-@rdfa_output:

- 3: [0] improper %rbp sandboxing

- return code: 1

-@validators_disagree:

- Same problem reported in different ways.

- errors reported by old validator but not by rdfa one:

- 0x0

- errors reported by rdfa validator but not by old one:

- 0x3