Delete old x86 validator.

src/trusted/validator_x86/testdata/64/legacy.test

Index: src/trusted/validator_x86/testdata/64/legacy.test
diff --git a/src/trusted/validator_x86/testdata/64/legacy.test b/src/trusted/validator_x86/testdata/64/legacy.test
deleted file mode 100644
index 8a33edc11cc9cfa0c4a9582b216dec8380cb942e..0000000000000000000000000000000000000000
--- a/src/trusted/validator_x86/testdata/64/legacy.test
+++ /dev/null
@@ -1,360 +0,0 @@
-@hex:
-  # Legacy instructions which are invalid in 64-bit mode
-  # nops (90) are used to reconsile disassembler
-  # aaa
-  37
-  # aad
-  D5 0A
-@rval:
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking block alignment and jump targets: 0 to 3
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 37                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d5                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: 37                                           invalid
-  0000000000000001: d5                                           invalid
-  0000000000000002: 0a                                           invalid
-@vdis:
-  0000000000000000: 37                                           invalid
-  0000000000000001: d5                                           invalid
-  0000000000000002: 0a                                           invalid
-@rdfa_output:
-  0: [0] unrecognized instruction
-  1: [1] unrecognized instruction
-  return code: 1
-@validators_disagree:
-  errors reported by old validator but not by rdfa one:
-    0x2 - because of error recovery
-----------------------------------------------------------------------
-@hex:
-  # aam
-  D4 0A
-@rval:
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking block alignment and jump targets: 0 to 2
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: d4                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 0a                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: d4                                           invalid
-  0000000000000001: 0a                                           invalid
-@vdis:
-  0000000000000000: d4                                           invalid
-  0000000000000001: 0a                                           invalid
-@rdfa_output:
-  0: [0] unrecognized instruction
-  return code: 1
-@validators_disagree:
-  errors reported by old validator but not by rdfa one:
-    0x1 - because of error recovery
-----------------------------------------------------------------------
-@hex:
-  # aas
-  3F
-  # bound %eax, (%eax)
-  62 00
-@rval:
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 00                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 00                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking block alignment and jump targets: 0 to 3
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 3f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 62                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 00                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: 3f                                           invalid
-  0000000000000001: 62                                           invalid
-  0000000000000002: 00                                           invalid
-@vdis:
-  0000000000000000: 3f                                           invalid
-  0000000000000001: 62                                           invalid
-  0000000000000002: 00                                           invalid
-@rdfa_output:
-  0: [0] unrecognized instruction
-  1: [1] unrecognized instruction
-  return code: 1
-@validators_disagree:
-  errors reported by old validator but not by rdfa one:
-    0x2 - because of error recovery
-----------------------------------------------------------------------
-@hex:
-  # daa
-  27
-  # das
-  2F
-  # pusha
-  60
-@rval:
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking block alignment and jump targets: 0 to 3
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: 27                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 2f                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000002: 60                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: 27                                           invalid
-  0000000000000001: 2f                                           invalid
-  0000000000000002: 60                                           invalid
-@vdis:
-  0000000000000000: 27                                           invalid
-  0000000000000001: 2f                                           invalid
-  0000000000000002: 60                                           invalid
-@rdfa_output:
-  0: [0] unrecognized instruction
-  1: [1] unrecognized instruction
-  2: [2] unrecognized instruction
-  return code: 1
-----------------------------------------------------------------------
-@hex:
-  # Some undocumented instructions
-  # icebp
-  F1
-  # salc
-  D6
-@rval:
-  VALIDATOR: 0000000000000000: f1                                           int1
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: f1                                           int1
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking block alignment and jump targets: 0 to 2
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: f1                                           [P] dontcare(illegal)
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: d6                                           invalid
-  VALIDATOR: ERROR: Opcode sequence doesn't define a valid x86 instruction
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: f1                                           int1
-  0000000000000001: d6                                           invalid
-@vdis:
-  0000000000000000: f1                                           [P] dontcare(illegal)
-  0000000000000001: d6                                           invalid
-@rdfa_output:
-  0: [0] unrecognized instruction
-  1: [1] unrecognized instruction
-  return code: 1
-----------------------------------------------------------------------
-@hex:
-  # Instruction below could be valid in 64-bit code and could be not valid
-  # depending on CPUID return values.
-  # lahf
-  9F
-  # sahf
-  9E
-@rval:
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> is safe ***
-@rvald:
-  VALIDATOR: Checking block alignment and jump targets: 0 to 2
-  *** <input> is safe ***
-@vd-rval:
-  VALIDATOR: Checking jump targets: 0 to 2
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> is safe ***
-@dis:
-  0000000000000000: 9f                                           lahf
-  0000000000000001: 9e                                           sahf
-@vdis:
-  0000000000000000: 9f                                           [P] dontcare %ah (s)
-  0000000000000001: 9e                                           [P] dontcare %ah (u)
-@rdfa_output:
-  return code: 0
-----------------------------------------------------------------------
-@hex:
-  # Legacy instructions which are valid in 64-bit mode
-  # xlat (%ebx,%al)
-  D7
-  
-  # xlat (%rbx,%al)
-  48 D7
-@rval:
-  VALIDATOR: 0000000000000000: d7                                           xlat
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: d7                                           xlat
-  VALIDATOR: ERROR: Segment memory reference not allowed
-  VALIDATOR: 0000000000000001: 48 d7                                        xlat
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 48 d7                                        xlat
-  VALIDATOR: ERROR: Segment memory reference not allowed
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000000: d7                                           xlat
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000000: d7                                           xlat
-  VALIDATOR: ERROR: Segment memory reference not allowed
-  VALIDATOR: 0000000000000001: 48 d7                                        xlat
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 48 d7                                        xlat
-  VALIDATOR: ERROR: Segment memory reference not allowed
-  VALIDATOR: Checking block alignment and jump targets: 0 to 3
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000000: d7                                           [P] dontcare(illegal)
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: 0000000000000001: 48 d7                                        [P] dontcare(illegal)
-  VALIDATOR: ERROR: This instruction has been marked illegal by Native Client
-  VALIDATOR: Checking jump targets: 0 to 3
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: d7                                           xlat
-  0000000000000001: 48 d7                                        xlat
-@vdis:
-  0000000000000000: d7                                           [P] dontcare(illegal)
-  0000000000000001: 48 d7                                        [P] dontcare(illegal)
-@rdfa_output:
-  0: [0] unrecognized instruction
-  1: [1] unrecognized instruction
-  return code: 1