Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/README

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_seg_sfi/README
diff --git a/src/trusted/validator/x86/ncval_seg_sfi/README b/src/trusted/validator/x86/ncval_seg_sfi/README
deleted file mode 100644
index edaec1aab54540d977991b4366a690d3c8a2e8e5..0000000000000000000000000000000000000000
--- a/src/trusted/validator/x86/ncval_seg_sfi/README
+++ /dev/null
@@ -1,46 +0,0 @@
-This directory contains the code for the native client verifier (ncv)
-which checks whether binaries adhere to certain control flow
-and instruction set restrictions. It assumes that segment registers
-are used to control memory accesses.
-
-Note: Although the current builds generate 64-bit versions, they do not
-make any sense, since segment registers have little effect in x86-64.
-
-Debugging
----------
-
-Many of the source files contain #define DEBUGGING flags. When
-DEBUGGING is set to 1, additional debugging print messages are
-compiled into the code. Unfortunately, by default, these message
-frequently call routines that are not compiled into corresponding
-executables (such as ncval and ncdis). To add the additional routines,
-edit file
-
- native_client/site_scons/site_tools/library_deps.py
-
-For x86-32, edit lines
-
- # When turning on the DEBUGGING flag in the x86-32 validator
- # or decoder, add the following:
- #'nc_opcode_modeling_verbose_x86_32',
-
-to
-
- # When turning on the DEBUGGING flag in the x86-32 validator
- # or decoder, add the following:
- 'nc_opcode_modeling_verbose_x86_32',
-
-For x86-64, edit lines
-
- # When turning on the DEBUGGING flag in the x86-64 validator
- # or decoder, add the following:
- # 'nc_opcode_modeling_verbose_x86_64',
-
-to
-
- # When turning on the DEBUGGING flag in the x86-64 validator
- # or decoder, add the following:
- 'nc_opcode_modeling_verbose_x86_64',
-
-These changes will make sure that the corresponding print routines are
-added to the executables during link time.

Powered by Google App Engine
This is Rietveld 408576698