Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h
diff --git a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h b/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h
deleted file mode 100644
index 866c741e985e26a1b374a044deb4efb642a51a1f..0000000000000000000000000000000000000000
--- a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h
+++ /dev/null
@@ -1,79 +0,0 @@
-/*
- * Copyright (c) 2012 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NCVALIDATE_ITER_DETAILED_H__
-#define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NCVALIDATE_ITER_DETAILED_H__
-
-/*
- * ncvalidate_iter_details.h: Secondary API for the validator to the
- * register-based sandbox.
- *
- * This is a secondary interface to the x86-64 validator for the register-based
- * sandbox. This version should be used when details about reporting errors
- * are needed. In particular, this interface should be used when the validator
- * is run in verbose or stubout mode. In these cases, getting details right
- * (i.e. the instruction that causes a code segment to violate NaCl rules)
- * is important. For verbose mode, this implies that the
- * error messages will report each instruction that violates a NaCl rule. For
- * stubout mode, it will automatically stub out (i.e. replace with HALT
- * instructions) instructions that violate NaCl rules.
- *
- * See ncvalidate_iter.h for the primary interface to the register-based sandbox
- * NaCl validator.
- *
- * This secondary interface is considerbly slower than the primary interface
- * in that it does two walks over the code segment instead of one. However, by
- * doing this second walk, it can generate more detailed error reports.
- * The secondary interface is engaged if one calls
- * NaClValidatorStateCreateDetailed in place of NaClValidatorStateCreate.
- * The rest of the interface to the NaCl validator is the same.
- *
- * Basic usage:
- * -- base is initial address of ELF file.
- * -- limit is the size of the ELF file.
- * -- maddr is the address to the memory of a section.
- * -- vaddr is the starting virtual address associated with a section.
- * -- size is the number of bytes in a section.
- *
- * if (!NaClArchSupported()) fail;
- * NaClValidatorState* state =
- * NaClValidatorStateCreateDetailed(base, limit - base, RegR15, features);
- * if (state == NULL) fail;
- * for each section:
- * NaClValidateSegment(maddr, vaddr, size, state);
- * if (!NaClValidatesOk(state)) fail;
- * NaClValidatorStateDestroy(state);
- *
- * See the README file in this directory for more info on the general
- * structure of the validator.
- */
-
-#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"
-
-/* Create a validator state to validate the code segment with the given
- * parameters, This state is set up to generate detailed errors instead
- * of summary (jump) errors.
- *
- * Note: Messages (if any) produced by the validator are sent to the stream
- * defined by native_client/src/shared/platform/nacl_log.h.
- *
- * Parameters.
- * vbase - The virtual address for the contents of the code segment.
- * sz - The number of bytes in the code segment
- * base_register - OperandKind defining value for base register (or
- * RegUnknown if not defined).
- * features - The CPU features to use. Uses local features of machine if NULL.
- * Returns:
- * A pointer to an initialized validator state if everything is ok, NULL
- * otherwise.
- */
-NaClValidatorState* NaClValidatorStateCreateDetailed(
- const NaClPcAddress vbase,
- const NaClMemorySize sz,
- const NaClOpKind base_register,
- const NaClCPUFeaturesX86 *features);
-
-#endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NCVALIDATE_ITER_DETAILED_H__ */

Powered by Google App Engine
This is Rietveld 408576698