Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h
diff --git a/src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h b/src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h
deleted file mode 100644
index 3757007f25b0dd6f6e56bbbb27db4effd8d60a47..0000000000000000000000000000000000000000
--- a/src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.h
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * Copyright (c) 2012 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NC_MEMORY_PROTECT_H__
-#define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NC_MEMORY_PROTECT_H__
-
-/* nc_memory_protect.h - For 64-bit mode, verifies that we don't access
- * memory that is out of range.
- */
-
-#include "native_client/src/shared/utils/types.h"
-#include "native_client/src/trusted/validator/x86/decoder/gen/ncopcode_operand_kind.h"
-
-struct NaClValidatorState;
-
-/*
- * When true, check both uses and sets of memory. When false, only
- * check sets.
- */
-extern Bool NACL_FLAGS_read_sandbox;
-
-/*
- * Verifies that we don't access memory store with an out of range
- * address. That implies that when storing (or reading when doing read
- * sandboxing), in a memory offset of the form:
- *
- * [base + index * scale + displacement]
- *
- * (1) base is either the reserved base register (r15), or rsp, or rbp.
- *
- * (2) Either the index isn't defined, or the index is a 32-bit register and
- * the previous instruction must assign a value to index that is 32-bits
- * with zero extension.
- *
- * (3) The displacement can't be larger than 32 bits.
- *
- * (4) Segment addresses s:b where s is in {CS, DS, ES, SS} and
- * b is a safe address generated by a LEA instruction.
- *
- * SPECIAL CASE: We allow all stores of the form [%rip + displacement].
- *
- * NOTE: in x86 code, displacements can't be larger than 32 bits.
- */
-void NaClMemoryReferenceValidator(struct NaClValidatorState* state);
-
-#ifdef NCVAL_TESTING
-/* Returns true if the current instruction is an LEA instruction that
- * generates a safe memory address.
- */
-Bool NaClAcceptLeaSafeAddress(struct NaClValidatorState* state);
-#endif
-
-#endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_REG_SFI_NC_MEMORY_PROTECT_H__ */

Powered by Google App Engine
This is Rietveld 408576698