Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: src/trusted/validator/x86/64/ncvalidate_verbose.c

Issue 625923004: Delete old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator/x86/64/ncvalidate.c ('k') | src/trusted/validator/x86/README » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/x86/64/ncvalidate_verbose.c
diff --git a/src/trusted/validator/x86/64/ncvalidate_verbose.c b/src/trusted/validator/x86/64/ncvalidate_verbose.c
deleted file mode 100644
index 3e62b6668f4d13888346cdaa96e5fc5a58ca493f..0000000000000000000000000000000000000000
--- a/src/trusted/validator/x86/64/ncvalidate_verbose.c
+++ /dev/null
@@ -1,61 +0,0 @@
-/*
- * Copyright (c) 2012 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-/* Implement the ApplyValidatorVerbosely API for the x86-64 architecture. */
-
-#include "native_client/src/trusted/validator/ncvalidate.h"
-
-#include "native_client/src/shared/platform/nacl_log.h"
-#include "native_client/src/trusted/cpu_features/arch/x86/cpu_x86.h"
-#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"
-#include "native_client/src/trusted/validator/x86/ncval_seg_sfi/ncdecode_verbose.h"
-#include "native_client/src/trusted/validator/x86/64/ncvalidate.h"
-#include <assert.h>
-
-/* Be sure the correct compile flags are defined for this. */
-#if NACL_ARCH(NACL_TARGET_ARCH) != NACL_x86
-# error("Can't compile, target is for x86-64")
-#else
-# if NACL_TARGET_SUBARCH != 64
-# error("Can't compile, target is for x86-64")
-# endif
-#endif
-
-static NaClValidationStatus NaClApplyValidatorVerbosely_x86_64(
- uintptr_t guest_addr,
- uint8_t *data,
- size_t size,
- const NaClCPUFeatures *f) {
- /* TODO(jfb) Use a safe cast here. */
- const NaClCPUFeaturesX86 *cpu_features = (NaClCPUFeaturesX86 *) f;
- struct NaClValidatorState *vstate;
- NaClValidationStatus status =
- NaClValidatorSetup_x86_64(guest_addr, size, FALSE, cpu_features, &vstate);
- if (status != NaClValidationSucceeded) return status;
- NaClValidatorStateSetLogVerbosity(vstate, LOG_ERROR);
- NaClValidatorStateSetMaxReportedErrors(vstate, -1); /* Report all errors. */
- NaClValidatorStateSetErrorReporter(vstate, &kNaClVerboseErrorReporter);
- NaClValidateSegment(data, guest_addr, size, vstate);
- status =
- NaClValidatesOk(vstate) ? NaClValidationSucceeded : NaClValidationFailed;
- NaClValidatorStateDestroy(vstate);
- return status;
-}
-
-NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorVerbosely, x86, 64)
- (uintptr_t guest_addr,
- uint8_t *data,
- size_t size,
- const NaClCPUFeatures *f) {
- /* TODO(jfb) Use a safe cast here. */
- const NaClCPUFeaturesX86 *cpu_features = (NaClCPUFeaturesX86 *) f;
-
- if (!NaClArchSupportedX86(cpu_features))
- return NaClValidationFailedCpuNotSupported;
-
- return NaClApplyValidatorVerbosely_x86_64(
- guest_addr, data, size, f);
-}
« no previous file with comments | « src/trusted/validator/x86/64/ncvalidate.c ('k') | src/trusted/validator/x86/README » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698