Delete old x86 validator.

src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test

Index: src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test
diff --git a/src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test b/src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test
deleted file mode 100644
index 8382c1bc0734565e34c1c579f7cc5249544f3268..0000000000000000000000000000000000000000
--- a/src/trusted/validator_x86/testdata/64/mov-lea-rbp-bad-4.test
+++ /dev/null
@@ -1,52 +0,0 @@
-@hex:
-  # Bad example of using lea solution (instead of add) to update rbp.
-  # That is, we add a (non-zero) constant to the address of the lea.
-  # base register r15.
-  #    mov %ebp, %ecx
-  #    lea %rbp, [%rbp+%r15*1+0x1]
-  89 cd
-  4a 8d 6c 3d 01
-@val:
-  VALIDATOR: 0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-  VALIDATOR: ERROR: Illegal change to register RBP
-  VALIDATOR: 0000000000000000: 89 cd                                        mov %ebp, %ecx
-  VALIDATOR: ERROR: Illegal assignment to EBP
-  VALIDATOR: Checking jump targets: 0 to 7
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rval:
-  VALIDATOR: 0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-  VALIDATOR: ERROR: Illegal change to register RBP
-  VALIDATOR: 0000000000000000: 89 cd                                        mov %ebp, %ecx
-  VALIDATOR: ERROR: Illegal assignment to EBP
-  VALIDATOR: Checking jump targets: 0 to 7
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@rvald:
-  VALIDATOR: 0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-  VALIDATOR: ERROR: Illegal change to register RBP
-  VALIDATOR: 0000000000000000: 89 cd                                        mov %ebp, %ecx
-  VALIDATOR: ERROR: Illegal assignment to EBP
-  VALIDATOR: Checking block alignment and jump targets: 0 to 7
-  *** <input> IS UNSAFE ***
-@vd-rval:
-  VALIDATOR: 0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-  VALIDATOR: ERROR: Illegal change to register RBP
-  VALIDATOR: 0000000000000000: 89 cd                                        mov %ebp, %ecx
-  VALIDATOR: ERROR: Illegal assignment to EBP
-  VALIDATOR: Checking jump targets: 0 to 7
-  VALIDATOR: Checking that basic blocks are aligned
-  *** <input> IS UNSAFE ***
-@dis:
-  0000000000000000: 89 cd                                        mov %ebp, %ecx
-  0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-@vdis:
-  0000000000000000: 89 cd                                        mov %ebp, %ecx
-  0000000000000002: 4a 8d 6c 3d 01                               lea %rbp, [%rbp+%r15*1+0x1]
-@rdfa_output:

[Mark Seaborn, 2014/10/06 17:40:04]

It looks like you're removing all of the targeted tests.  We don't want to do
that...

[Vlad Shcherbina, 2014/10/06 18:01:50]

No, real targeted tests are in src/trusted/validator_ragel/testdata/. Originally
they were copied from here, but since then diverged: old validator and
disassembler outputs were removed from them, spec (regex-based) validator
expectations were added. In addition, I did a lot to improve quality of those
tests (partitioned them into smaller units, deduplicateed, improved comments,
fixed defects in tests, added tests for other interesting cases; overall number
of testcases went from ~300 to ~530; issue 3487). 

All these changes were not reflected in validator_x86/testdata tests.

It is awesome that Shyamsundar is deleting this piece of legacy.

-  2: [0] improper %rbp sandboxing
-  2: [0] error - %bpl or %bp is changed
-  return code: 1
-@validators_disagree:
-  errors reported by old validator but not by rdfa one:
-    0x0 - same error, but it's reported by RDFA differently